adium 5053:2daa5af4cb55: I think this should not be weak, it mak...

commits at adium.im commits at adium.im
Wed Sep 12 10:55:55 UTC 2012


details:	http://hg.adium.im/adium/rev/2daa5af4cb55
revision:	5053:2daa5af4cb55
branch:		(none)
author:		Thijs Alkemade <thijsalkemade at gmail.com>
date:		Wed Sep 12 12:54:47 2012 +0200

I think this should not be weak, it makes activeAppenders turn nil for me, causing all sorts of problems with log files.

diffs (24 lines):

diff -r de29b6d93baf -r 2daa5af4cb55 Source/AILoggerPlugin.h
--- a/Source/AILoggerPlugin.h	Wed Sep 12 12:17:15 2012 +0200
+++ b/Source/AILoggerPlugin.h	Wed Sep 12 12:54:47 2012 +0200
@@ -40,7 +40,7 @@
 	
 	// Logging
 	SKIndexRef           logIndex;
-	NSMutableDictionary *__weak activeAppenders;
+	NSMutableDictionary *activeAppenders;
 	AIHTMLDecoder       *xhtmlDecoder;
 	NSDictionary        *statusTranslation;
 	BOOL                 logHTML;
diff -r de29b6d93baf -r 2daa5af4cb55 Source/AILoggerPlugin.m
--- a/Source/AILoggerPlugin.m	Wed Sep 12 12:17:15 2012 +0200
+++ b/Source/AILoggerPlugin.m	Wed Sep 12 12:54:47 2012 +0200
@@ -139,7 +139,7 @@
 - (void)_flushIndex:(SKIndexRef)inIndex;
 
 // properties
- at property(weak, readwrite) NSMutableDictionary *activeAppenders;
+ at property(strong, readwrite) NSMutableDictionary *activeAppenders;
 @property(readwrite, strong) AIHTMLDecoder       *xhtmlDecoder;
 @property(readwrite, strong) NSDictionary        *statusTranslation;
 @property(strong,readwrite) NSMutableSet        *dirtyLogSet;




More information about the commits mailing list