adium 4827:ee0177c76224: The probably-smart behavior for Use Cli...

[commits at adium.im]

details:	http://hg.adium.im/adium/rev/ee0177c76224
revision:	4827:ee0177c76224
branch:		adium-1.5.1
author:		Evan Schoenberg
date:		Mon May 14 17:20:32 2012 -0500

The probably-smart behavior for Use Client Login for OSCAR accounts doesn't work for everyone. We probably need to add this as an actual account preference, sadly, but here's an easy stopgap that doesn't require a round of updated localization. Added hidden preference 'AIUseClientLoginWithProxies'. Refs #15137 where MG55 needs this to be able to connect; it doens't fix the issue of OP (deesto) in that ticket, which is completely beyond my comprehension.

diffs (15 lines):

diff -r b8ccb58ad86f -r ee0177c76224 Plugins/Purple Service/CBPurpleOscarAccount.m
--- a/Plugins/Purple Service/CBPurpleOscarAccount.m	Mon May 14 10:08:41 2012 +0200
+++ b/Plugins/Purple Service/CBPurpleOscarAccount.m	Mon May 14 17:20:32 2012 -0500
@@ -117,9 +117,9 @@
     if ((purple_proxy_info_get_type(proxy_info) != PURPLE_PROXY_NONE) && 
         purple_proxy_info_get_host(proxy_info) && strlen(purple_proxy_info_get_host(proxy_info))) {
         /* Proxy servers and client login don't currently get along.  This should be fixed in libpurple, but until then,
-         * just don't use it.
+         * just don't use it, unless the hidden preference is set.
          */
-        purple_account_set_bool(account, "use_clientlogin", FALSE);
+		purple_account_set_bool(account, "use_clientlogin", [[NSUserDefaults standardUserDefaults] boolForKey:@"AIUseClientLoginWithProxies"]);
     }
         
     [super continueConnectWithConfiguredProxy];