adium 4586:390ae762fd61: This leak fix was wrong. NSWindowContro...

commits at adium.im commits at adium.im
Sun Jan 29 12:45:13 UTC 2012


details:	http://hg.adium.im/adium/rev/390ae762fd61
revision:	4586:390ae762fd61
branch:		(none)
author:		Thijs Alkemade <thijsalkemade at gmail.com>
date:		Sun Jan 29 13:44:41 2012 +0100

This leak fix was wrong. NSWindowController subclasses aren't released until -windowWillClose:

diffs (12 lines):

diff -r 6c1dd8c3ee4a -r 390ae762fd61 Source/AIURLHandlerPlugin.m
--- a/Source/AIURLHandlerPlugin.m	Sun Jan 29 02:53:09 2012 +0100
+++ b/Source/AIURLHandlerPlugin.m	Sun Jan 29 13:44:41 2012 +0100
@@ -527,7 +527,7 @@
 	}
 	
 	if (!ircAccount) {
-		[[[AITemporaryIRCAccountWindowController alloc] initWithChannel:name server:server port:port andPassword:password] autorelease];
+		[[AITemporaryIRCAccountWindowController alloc] initWithChannel:name server:server port:port andPassword:password];
 	} else if (name) {
 		[adium.chatController chatWithName:name
 		 identifier:nil




More information about the commits mailing list