adium 4577:c0ad36313b1f: Fixed a bunch of "Argument to 'NSDictio...

[commits at adium.im]

details:	http://hg.adium.im/adium/rev/c0ad36313b1f
revision:	4577:c0ad36313b1f
branch:		(none)
author:		Adrian Godoroja <robotive at me.com>
date:		Sat Jan 28 22:43:36 2012 +0200

Fixed a bunch of "Argument to 'NSDictionary' method 'dictionaryWithObjectsAndKeys:' should be an Objective-C pointer type, not '_SOME_Ref'". Analyzer Warnings--.

diffs (123 lines):

diff -r e537c0829dde -r c0ad36313b1f Frameworks/AIUtilities Framework/Source/AIHostReachabilityMonitor.m
--- a/Frameworks/AIUtilities Framework/Source/AIHostReachabilityMonitor.m	Fri Jan 27 18:43:27 2012 +0200
+++ b/Frameworks/AIUtilities Framework/Source/AIHostReachabilityMonitor.m	Sat Jan 28 22:43:36 2012 +0200
@@ -364,7 +364,7 @@
 							self, @"self",
 							host, @"host",
 							observer, @"observer",
-							reachabilityRef, @"reachabilityRef",
+							[NSValue valueWithPointer:reachabilityRef], @"reachabilityRef",
 							nil],
 						.retain			 = CFRetain,
 						.release		 = CFRelease,
diff -r e537c0829dde -r c0ad36313b1f Frameworks/AIUtilities Framework/Source/AIKeychain.m
--- a/Frameworks/AIUtilities Framework/Source/AIKeychain.m	Fri Jan 27 18:43:27 2012 +0200
+++ b/Frameworks/AIUtilities Framework/Source/AIKeychain.m	Sat Jan 28 22:43:36 2012 +0200
@@ -498,7 +498,7 @@
 				[NSValue valueWithPointer:SecKeychainGetPath], AIKEYCHAIN_ERROR_USERINFO_SECURITYFUNCTION,
 				@"SecKeychainGetPath", AIKEYCHAIN_ERROR_USERINFO_SECURITYFUNCTIONNAME,
 				AI_LOCALIZED_SECURITY_ERROR_DESCRIPTION(err), AIKEYCHAIN_ERROR_USERINFO_ERRORDESCRIPTION,
-				targetKeychainRef, AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
+				[NSValue valueWithPointer:targetKeychainRef], AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
 				nil];
 			
 			if (outError) {
@@ -548,7 +548,7 @@
 				[NSValue valueWithPointer:SecKeychainLock], AIKEYCHAIN_ERROR_USERINFO_SECURITYFUNCTION,
 				@"SecKeychainLock", AIKEYCHAIN_ERROR_USERINFO_SECURITYFUNCTIONNAME,
 				AI_LOCALIZED_SECURITY_ERROR_DESCRIPTION(err), AIKEYCHAIN_ERROR_USERINFO_ERRORDESCRIPTION,
-				keychainRef, AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
+				[NSValue valueWithPointer:keychainRef], AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
 				nil];
 			error = [NSError errorWithDomain:AIKEYCHAIN_ERROR_DOMAIN code:err userInfo:userInfo];
 		}
@@ -572,7 +572,7 @@
 				[NSValue valueWithPointer:SecKeychainUnlock], AIKEYCHAIN_ERROR_USERINFO_SECURITYFUNCTION,
 				@"SecKeychainUnlock", AIKEYCHAIN_ERROR_USERINFO_SECURITYFUNCTIONNAME,
 				AI_LOCALIZED_SECURITY_ERROR_DESCRIPTION(err), AIKEYCHAIN_ERROR_USERINFO_ERRORDESCRIPTION,
-				keychainRef, AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
+				[NSValue valueWithPointer:keychainRef], AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
 				nil];
 			error = [NSError errorWithDomain:AIKEYCHAIN_ERROR_DOMAIN code:err userInfo:userInfo];
 		}
@@ -603,7 +603,7 @@
 				[NSValue valueWithPointer:SecKeychainUnlock], AIKEYCHAIN_ERROR_USERINFO_SECURITYFUNCTION,
 				@"SecKeychainUnlock", AIKEYCHAIN_ERROR_USERINFO_SECURITYFUNCTIONNAME,
 				AI_LOCALIZED_SECURITY_ERROR_DESCRIPTION(err), AIKEYCHAIN_ERROR_USERINFO_ERRORDESCRIPTION,
-				keychainRef, AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
+				[NSValue valueWithPointer:keychainRef], AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
 				nil];
 			error = [NSError errorWithDomain:AIKEYCHAIN_ERROR_DOMAIN code:err userInfo:userInfo];
 		}
@@ -637,7 +637,7 @@
 					[NSValue valueWithPointer:SecKeychainDelete], AIKEYCHAIN_ERROR_USERINFO_SECURITYFUNCTION,
 					@"SecKeychainDelete", AIKEYCHAIN_ERROR_USERINFO_SECURITYFUNCTIONNAME,
 					AI_LOCALIZED_SECURITY_ERROR_DESCRIPTION(err), AIKEYCHAIN_ERROR_USERINFO_ERRORDESCRIPTION,
-					targetKeychainRef, AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
+					[NSValue valueWithPointer:targetKeychainRef], AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
 					nil];
 				error = [NSError errorWithDomain:AIKEYCHAIN_ERROR_DOMAIN code:err userInfo:userInfo];
 			}
@@ -718,7 +718,7 @@
 				account, AIKEYCHAIN_ERROR_USERINFO_ACCOUNT,
 				NSFileTypeForHFSTypeCode(protocol), AIKEYCHAIN_ERROR_USERINFO_PROTOCOL,
 				NSFileTypeForHFSTypeCode(authType), AIKEYCHAIN_ERROR_USERINFO_AUTHENTICATIONTYPE,
-				keychainRef, AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
+				[NSValue valueWithPointer:keychainRef], AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
 				nil];
 			error = [NSError errorWithDomain:AIKEYCHAIN_ERROR_DOMAIN code:err userInfo:userInfo];
 		}
@@ -800,7 +800,7 @@
 				account, AIKEYCHAIN_ERROR_USERINFO_ACCOUNT,
 				NSFileTypeForHFSTypeCode(protocol), AIKEYCHAIN_ERROR_USERINFO_PROTOCOL,
 				NSFileTypeForHFSTypeCode(authType), AIKEYCHAIN_ERROR_USERINFO_AUTHENTICATIONTYPE,
-				keychainRef, AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
+				[NSValue valueWithPointer:keychainRef], AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
 				nil];
 			error = [NSError errorWithDomain:AIKEYCHAIN_ERROR_DOMAIN code:err userInfo:userInfo];
 		}
@@ -1004,7 +1004,7 @@
 								account, AIKEYCHAIN_ERROR_USERINFO_ACCOUNT,
 								NSFileTypeForHFSTypeCode(protocol), AIKEYCHAIN_ERROR_USERINFO_PROTOCOL,
 								NSFileTypeForHFSTypeCode(authType), AIKEYCHAIN_ERROR_USERINFO_AUTHENTICATIONTYPE,
-								keychainRef, AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
+								[NSValue valueWithPointer:keychainRef], AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
 								nil];
 							// Retain this because of the autorelease pool
 							error = [[NSError errorWithDomain:AIKEYCHAIN_ERROR_DOMAIN code:err userInfo:userInfo] retain];
@@ -1087,7 +1087,7 @@
 					account, AIKEYCHAIN_ERROR_USERINFO_ACCOUNT,
 					NSFileTypeForHFSTypeCode(protocol), AIKEYCHAIN_ERROR_USERINFO_PROTOCOL,
 					NSFileTypeForHFSTypeCode(kSecAuthenticationTypeDefault), AIKEYCHAIN_ERROR_USERINFO_AUTHENTICATIONTYPE,
-					keychainRef, AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
+					[NSValue valueWithPointer:keychainRef], AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
 					nil];
 				error = [NSError errorWithDomain:AIKEYCHAIN_ERROR_DOMAIN code:err userInfo:userInfo];
 			}
@@ -1169,7 +1169,7 @@
 				AI_LOCALIZED_SECURITY_ERROR_DESCRIPTION(err), AIKEYCHAIN_ERROR_USERINFO_ERRORDESCRIPTION,
 				service, AIKEYCHAIN_ERROR_USERINFO_SERVICE,
 				account, AIKEYCHAIN_ERROR_USERINFO_ACCOUNT,
-				keychainRef, AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
+				[NSValue valueWithPointer:keychainRef], AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
 				nil];
 			error = [NSError errorWithDomain:AIKEYCHAIN_ERROR_DOMAIN code:err userInfo:userInfo];
 		}
@@ -1212,7 +1212,7 @@
 				AI_LOCALIZED_SECURITY_ERROR_DESCRIPTION(err), AIKEYCHAIN_ERROR_USERINFO_ERRORDESCRIPTION,
 				service, AIKEYCHAIN_ERROR_USERINFO_SERVICE,
 				account, AIKEYCHAIN_ERROR_USERINFO_ACCOUNT,
-				keychainRef, AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
+				[NSValue valueWithPointer:keychainRef], AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
 				nil];
 			error = [NSError errorWithDomain:AIKEYCHAIN_ERROR_DOMAIN code:err userInfo:userInfo];
 		}
@@ -1256,7 +1256,7 @@
 										  service,  AIKEYCHAIN_ERROR_USERINFO_SERVICE,
 										  account, AIKEYCHAIN_ERROR_USERINFO_ACCOUNT,
 										  NSFileTypeForHFSTypeCode(kSecAuthenticationTypeDefault), AIKEYCHAIN_ERROR_USERINFO_AUTHENTICATIONTYPE,
-										  keychainRef, AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
+										  [NSValue valueWithPointer:keychainRef], AIKEYCHAIN_ERROR_USERINFO_KEYCHAIN,
 										  nil];
 				error = [NSError errorWithDomain:AIKEYCHAIN_ERROR_DOMAIN code:err userInfo:userInfo];
 			}