adium 4976:24f97317aca7: I think this code is unused, I can't fi...

[commits at adium.im]

details:	http://hg.adium.im/adium/rev/24f97317aca7
revision:	4976:24f97317aca7
branch:		(none)
author:		Thijs Alkemade <thijsalkemade at gmail.com>
date:		Wed Aug 08 20:57:16 2012 +0200

I think this code is unused, I can't find any other reference to LogIsDirty_, and this confused ESObjectWithProperties.
Subject: adium 4977:e253db549c60: Fix the length to match what's asserted.

details:	http://hg.adium.im/adium/rev/e253db549c60
revision:	4977:e253db549c60
branch:		(none)
author:		Thijs Alkemade <thijsalkemade at gmail.com>
date:		Wed Aug 08 20:57:35 2012 +0200

Fix the length to match what's asserted.

diffs (62 lines):

diff -r 6c064c1c2d07 -r e253db549c60 Frameworks/Adium Framework/Source/ESObjectWithProperties.m
--- a/Frameworks/Adium Framework/Source/ESObjectWithProperties.m	Wed Aug 08 16:48:23 2012 +0200
+++ b/Frameworks/Adium Framework/Source/ESObjectWithProperties.m	Wed Aug 08 20:57:35 2012 +0200
@@ -84,7 +84,7 @@
 	
 	NSAssert([key length] < 256, @"Too long property!");
 	
-	[key getCString:property_name maxLength:32 encoding:NSUTF8StringEncoding];
+	[key getCString:property_name maxLength:256 encoding:NSUTF8StringEncoding];
 	
 	Ivar ivar = class_getInstanceVariable([self class], property_name);
 	
@@ -212,7 +212,7 @@
 	
 	NSAssert([key length] < 256, @"Too long property!");
 	
-	[key getCString:property_name maxLength:32 encoding:NSUTF8StringEncoding];
+	[key getCString:property_name maxLength:256 encoding:NSUTF8StringEncoding];
 	
 	Ivar ivar = object_getInstanceVariable(self, property_name, (void **)&value);
 	
@@ -256,7 +256,7 @@
 	
 	NSAssert([key length] < 256, @"Too long property!");
 	
-	[key getCString:property_name maxLength:32 encoding:NSUTF8StringEncoding];
+	[key getCString:property_name maxLength:256 encoding:NSUTF8StringEncoding];
 	
 	Ivar ivar = class_getInstanceVariable([self class], property_name);
 	
@@ -295,7 +295,7 @@
 	
 	NSAssert([key length] < 256, @"Too long property!");
 	
-	[key getCString:property_name maxLength:32 encoding:NSUTF8StringEncoding];
+	[key getCString:property_name maxLength:256 encoding:NSUTF8StringEncoding];
 	
 	Ivar ivar = class_getInstanceVariable([self class], property_name);
 	
diff -r 6c064c1c2d07 -r e253db549c60 Source/AILoggerPlugin.m
--- a/Source/AILoggerPlugin.m	Wed Aug 08 16:48:23 2012 +0200
+++ b/Source/AILoggerPlugin.m	Wed Aug 08 20:57:35 2012 +0200
@@ -1632,19 +1632,6 @@
 		OSAtomicCompareAndSwap64Barrier(bself->logsToIndex, [bself->dirtyLogSet count], (int64_t *)&(bself->logsToIndex));
 	});
 	
-	//Clear the dirty status of all open chats so they will be marked dirty if they receive another message
-	for (AIChat *chat in adium.chatController.openChats) {
-		NSString *existingAppenderPath = [[self _existingAppenderForChat:chat] path];
-		if (existingAppenderPath) {
-			NSString *dirtyKey = [@"LogIsDirty_" stringByAppendingString:existingAppenderPath];
-			
-			if ([chat integerValueForProperty:dirtyKey]) {
-				[chat setValue:nil
-				   forProperty:dirtyKey
-						notify:NotifyNever];
-			}
-		}
-	}
 	self.isIndexing = NO;
 	dispatch_async(dispatch_get_main_queue(), ^{
 		[[AILogViewerWindowController existingWindowController] logIndexingProgressUpdate];