xtras/mathuaerknedam 571:97d8bb84088e: Use a attribute user="" i...

commits at adium.im commits at adium.im
Fri Mar 25 19:46:13 UTC 2011


details:	http://hg.adium.im/xtras/mathuaerknedam/rev/97d8bb84088e
revision:	571:97d8bb84088e
branch:		(none)
author:		Thijs Alkemade <thijsalkemade at gmail.com>
date:		Fri Mar 25 20:45:35 2011 +0100

Use a attribute user="" instead of a class of "xx-" for usernames, and optimize the highlighting.

diffs (135 lines):

diff -r 5ff956b064fe -r 97d8bb84088e Resources/Message Styles/yMous.AdiumMessageStyle/Contents/Resources/Content.html
--- a/Resources/Message Styles/yMous.AdiumMessageStyle/Contents/Resources/Content.html	Mon Mar 07 15:38:50 2011 -0600
+++ b/Resources/Message Styles/yMous.AdiumMessageStyle/Contents/Resources/Content.html	Fri Mar 25 20:45:35 2011 +0100
@@ -1,4 +1,4 @@
-<div class="%messageClasses% %service% %userIcons% xx-%senderScreenName%" style="background-color: %senderColor%;" title="%senderPrefix% %senderScreenName%%status% · %service% · %time% · %time{dd MMM yyyy}%">
+<div class="%messageClasses% %service% %userIcons%" user="%senderScreenName%" style="background-color: %senderColor%;" title="%senderPrefix% %senderScreenName%%status% · %service% · %time% · %time{dd MMM yyyy}%">
 	<span class="x-focus"></span>
 	<span class="x-icon"><img src="%userIconPath%" /></span>
 	<span class="x-sender">%sender%</span>
diff -r 5ff956b064fe -r 97d8bb84088e Resources/Message Styles/yMous.AdiumMessageStyle/Contents/Resources/Footer.js
--- a/Resources/Message Styles/yMous.AdiumMessageStyle/Contents/Resources/Footer.js	Mon Mar 07 15:38:50 2011 -0600
+++ b/Resources/Message Styles/yMous.AdiumMessageStyle/Contents/Resources/Footer.js	Fri Mar 25 20:45:35 2011 +0100
@@ -6,24 +6,25 @@
 		highlightActive = true;
 		var node = event.target;
 		var senderName = null;
+
 		while (!senderName) {
-			var nodeClass = node.className;
-			if (/(^|[\s])message/.test(nodeClass)) {
-				var parts = nodeClass.split(" ");
-				senderName = parts[parts.length - 1];
-			}
+			var senderName = node.getAttribute("user");
 			node = node.parentElement;
 		}
-		var elms = document.getElementsByClassName(senderName); var elemArray = new Array(elms.length); for (var i=0; i<elms.length; i++) { elemArray[i]=elms[i]; }
-		var len = elemArray.length;
-		for(var i = 0; i < len; i++) {
-			var elem = elms[i];
-			if(elem.offsetTop + elem.offsetHeight >= window.pageYOffset) {
-				if(elem.offsetTop > window.pageYOffset + window.innerHeight) {
+		
+		if (!senderName || senderName == "") {
+		  return;
+		}
+
+		var elms = document.getElementsByClassName("message");
+
+		for (i = 0; i < elms.length; i++) {
+			elm = elms[i];
+			if (elm.getAttribute("user") == senderName && elm.offsetTop + elm.offsetHeight >= window.pageYOffset) {
+				if(elm.offsetTop > window.pageYOffset + window.innerHeight) {
 					break;
 				}
-				elemArray.push(elem);
-				elem.className += ' x-hover';
+				elm.className += ' x-hover';
 			}
 		}
 	}
diff -r 5ff956b064fe -r 97d8bb84088e Resources/Message Styles/yMous.AdiumMessageStyle/Contents/Resources/Mockup.html
--- a/Resources/Message Styles/yMous.AdiumMessageStyle/Contents/Resources/Mockup.html	Mon Mar 07 15:38:50 2011 -0600
+++ b/Resources/Message Styles/yMous.AdiumMessageStyle/Contents/Resources/Mockup.html	Fri Mar 25 20:45:35 2011 +0100
@@ -63,7 +63,7 @@
 <span class="x-time">12:45:48</span>
 </div>
 
-<div class="hideIcons SERVICE history outgoing message xx-TekJew" style="background-color: seagreen;" title="Evan · AIM · 12:45:48 · 19 Apr 2004">
+<div class="hideIcons SERVICE history outgoing message" user="TekJew" style="background-color: seagreen;" title="Evan · AIM · 12:45:48 · 19 Apr 2004">
 <span class="x-focus"></span>
 <span class="x-icon"><img src="./outgoing_icon.png" /></span>
 <span class="x-sender">Evan</span>
@@ -75,7 +75,7 @@
 <span class="x-time">12:45:48</span>
 </div>
 
-<div class="hideIcons SERVICE history incoming message mention xx-fetchgreebledonx" style="background-color: blue;" title="Jeff · AIM · 12:46:07 · 19 Apr 2004">
+<div class="hideIcons SERVICE history incoming message mention" user="fetchgreebledonx" style="background-color: blue;" title="Jeff · AIM · 12:46:07 · 19 Apr 2004">
 <span class="x-focus"></span>
 <span class="x-icon"><img src="./incoming_icon.png" /></span>
 <span class="x-sender">Jeff</span>
@@ -87,7 +87,7 @@
 <span class="x-time">12:46:07</span>
 </div>
 
-<div class="hideIcons SERVICE history consecutive incoming message xx-fetchgreebledonx" style="background-color: blue;" title="Jeff · AIM · 12:46:32 · 19 Apr 2004">
+<div class="hideIcons SERVICE history consecutive incoming message" user="fetchgreebledonx" style="background-color: blue;" title="Jeff · AIM · 12:46:32 · 19 Apr 2004">
 <span class="x-focus"></span>
 <span class="x-icon"><img src="./incoming_icon.png" /></span>
 <span class="x-sender">Jeff</span>
@@ -99,7 +99,7 @@
 <span class="x-time">12:46:32</span>
 </div>
 
-<div class="hideIcons SERVICE outgoing message xx-TekJew" style="background-color: seagreen;" title="Evan · AIM · 12:46:50 · 19 Apr 2004">
+<div class="hideIcons SERVICE outgoing message" user="TekJew" style="background-color: seagreen;" title="Evan · AIM · 12:46:50 · 19 Apr 2004">
 <span class="x-focus"></span>
 <span class="x-icon"><img src="./outgoing_icon.png" /></span>
 <span class="x-sender">Evan</span>
@@ -111,7 +111,7 @@
 <span class="x-time">12:46:50</span>
 </div>
 
-<div class="hideIcons SERVICE action consecutive outgoing message xx-TekJew" style="background-color: seagreen;" title="Evan · AIM · 12:47:00 · 19 Apr 2004">
+<div class="hideIcons SERVICE action consecutive outgoing message" user="TekJew" style="background-color: seagreen;" title="Evan · AIM · 12:47:00 · 19 Apr 2004">
 <span class="x-focus"></span>
 <span class="x-icon"><img src="./outgoing_icon.png" /></span>
 <span class="x-sender">Evan</span>
@@ -123,7 +123,7 @@
 <span class="x-time">12:47:00</span>
 </div>
 
-<div class="hideIcons SERVICE incoming message mention xx-fetchgreebledonx" style="background-color: blue;" title="Jeff · AIM · 12:47:06 · 19 Apr 2004">
+<div class="hideIcons SERVICE incoming message mention" user="fetchgreebledonx" style="background-color: blue;" title="Jeff · AIM · 12:47:06 · 19 Apr 2004">
 <span class="x-focus"></span>
 <span class="x-icon"><img src="./incoming_icon.png" /></span>
 <span class="x-sender">Jeff</span>
@@ -135,7 +135,7 @@
 <span class="x-time">12:47:06</span>
 </div>
 
-<div class="hideIcons SERVICE outgoing message xx-TekJew" style="background-color: seagreen;" title="Evan · AIM · 12:47:51 · 19 Apr 2004">
+<div class="hideIcons SERVICE outgoing message" user="TekJew" style="background-color: seagreen;" title="Evan · AIM · 12:47:51 · 19 Apr 2004">
 <span class="x-focus"></span>
 <span class="x-icon"><img src="./outgoing_icon.png" /></span>
 <span class="x-sender">Evan</span>
@@ -171,7 +171,7 @@
 <span class="x-time">12:47:55</span>
 </div>
 
-<div class="hideIcons SERVICE firstFocus focus incoming message auto_reply xx-fetchgreebledonx" style="background-color: blue;" title="Jeff · AIM (Autoreply) · 12:47:51 · 19 Apr 2004">
+<div class="hideIcons SERVICE firstFocus focus incoming message auto_reply" user="fetchgreebledonx" style="background-color: blue;" title="Jeff · AIM (Autoreply) · 12:47:51 · 19 Apr 2004">
 <span class="x-focus"></span>
 <span class="x-icon"><img src="./incoming_icon.png" /></span>
 <span class="x-sender">Jeff (Autoreply)</span>
@@ -183,7 +183,7 @@
 <span class="x-time">12:47:51</span>
 </div>
 
-<div class="hideIcons SERVICE focus outgoing message xx-TekJew" style="background-color: seagreen;" title="Evan · AIM · 12:48:02 · 19 Apr 2004">
+<div class="hideIcons SERVICE focus outgoing message" user="TekJew" style="background-color: seagreen;" title="Evan · AIM · 12:48:02 · 19 Apr 2004">
 <span class="x-focus"></span>
 <span class="x-icon"><img src="./outgoing_icon.png" /></span>
 <span class="x-sender">Evan</span>




More information about the commits mailing list