adium-1.4 3571:646dca67f2ec: Fixed handling of cookies in the Fa...

commits at adium.im commits at adium.im
Sat Jul 16 22:51:01 UTC 2011


details:	http://hg.adium.im/adium-1.4/rev/646dca67f2ec
revision:	3571:646dca67f2ec
branch:		(none)
author:		Evan Schoenberg
date:		Sat Jul 16 17:49:16 2011 -0500

Fixed handling of cookies in the Facebook web auth code such that it continues to work if cookie.portList returns an empty NSArray for a nonexistant portList. Fixes #15300
(transplanted from 830a902a0960cf3d7fd55bebd2a18ac9c4fa9c0e)

diffs (12 lines):

diff -r 6232a1951a87 -r 646dca67f2ec Plugins/Purple Service/AIFacebookXMPPOAuthWebViewWindowController.m
--- a/Plugins/Purple Service/AIFacebookXMPPOAuthWebViewWindowController.m	Sat Jul 16 23:54:20 2011 +0200
+++ b/Plugins/Purple Service/AIFacebookXMPPOAuthWebViewWindowController.m	Sat Jul 16 17:49:16 2011 -0500
@@ -204,7 +204,7 @@
             }
         }
         
-        if ([cookie portList] && ![[cookie portList] containsObject:[requestURL port]]) {
+        if ([[cookie portList] count] && ([requestURL port] != NULL) && ![[cookie portList] containsObject:[requestURL port]]) {
             AILogWithSignature(@"Skipping cookie: port mismatch: %@", cookie);
             continue;
         }




More information about the commits mailing list