adium-1.4 3655:7b4fa56e0504: According to http://twitter.com/#!/...
commits at adium.im
commits at adium.im
Thu Dec 8 17:24:58 UTC 2011
details: http://hg.adium.im/adium-1.4/rev/7b4fa56e0504
revision: 3655:7b4fa56e0504
branch: (none)
author: Robert Vehse
date: Thu Dec 08 18:24:48 2011 +0100
According to http://twitter.com/#!/beatak/status/144815414931755008, #15674 also occurs in 1.4.4.
http://hg.adium.im/adium/rev/5938f683a691: "Ensure that this view object lives beyond the lifetime of its window controller. Fixes #15674."
diffs (32 lines):
diff -r 229b6b0dde50 -r 7b4fa56e0504 ChangeLogs/Changes.txt
--- a/ChangeLogs/Changes.txt Mon Dec 05 00:14:06 2011 +0100
+++ b/ChangeLogs/Changes.txt Thu Dec 08 18:24:48 2011 +0100
@@ -1,5 +1,8 @@
Adium Version History
-----------------------
+Adium 1.4.5 (X/X/X)
+ * Fixed crash when sending certain group chat requests. (#15674)
+
Version 1.4.4 (12/5/2011)
Services
* Facebook: Fixed connectivity. (#15544, #15583)
diff -r 229b6b0dde50 -r 7b4fa56e0504 Frameworks/Adium Framework/Source/DCJoinChatViewController.m
--- a/Frameworks/Adium Framework/Source/DCJoinChatViewController.m Mon Dec 05 00:14:06 2011 +0100
+++ b/Frameworks/Adium Framework/Source/DCJoinChatViewController.m Thu Dec 08 18:24:48 2011 +0100
@@ -119,7 +119,7 @@
[chat setValue:invitationMessage forProperty:@"InitialInivitationMessage" notify:NotifyNever];
}
- [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(chatDidOpen:) name:Chat_DidOpen object:chat];
+ [[NSNotificationCenter defaultCenter] addObserver:[self retain] selector:@selector(chatDidOpen:) name:Chat_DidOpen object:chat];
}
}
@@ -154,6 +154,7 @@
//We are no longer concerned with the opening of this chat.
[[NSNotificationCenter defaultCenter] removeObserver:self name:Chat_DidOpen object:chat];
+ [self release];
}
/*!
More information about the commits
mailing list