adium 4334:5938f683a691: Ensure that this view object lives beyo...

commits at adium.im commits at adium.im
Thu Dec 1 07:57:19 UTC 2011


details:	http://hg.adium.im/adium/rev/5938f683a691
revision:	4334:5938f683a691
branch:		(none)
author:		Stephen Holt <sholt at adium.im>
date:		Wed Nov 30 23:57:17 2011 -0800

Ensure that this view object lives beyond the lifetime of its window controller. Fixes #15674.

diffs (31 lines):

diff -r 6e7db5aeabcc -r 5938f683a691 ChangeLogs/Changes Between Betas.txt
--- a/ChangeLogs/Changes Between Betas.txt	Wed Nov 30 20:19:10 2011 -0800
+++ b/ChangeLogs/Changes Between Betas.txt	Wed Nov 30 23:57:17 2011 -0800
@@ -3,6 +3,7 @@
  * Correct strange behavior in the messages pref pane. (#15670)
  * Fixed a 2px alignment issue when a normal or borderless contact window is set to vertically resize automatically. (#15626)
  * Restored bouncy scroll behavior to normal window style contact list windows.
+ * Fixed crash when sending certain group chat requests. (#15674)
 
 Adium 1.5b5
  * Fixed crash when loading Skype plugin. (#15590)
diff -r 6e7db5aeabcc -r 5938f683a691 Frameworks/Adium Framework/Source/DCJoinChatViewController.m
--- a/Frameworks/Adium Framework/Source/DCJoinChatViewController.m	Wed Nov 30 20:19:10 2011 -0800
+++ b/Frameworks/Adium Framework/Source/DCJoinChatViewController.m	Wed Nov 30 23:57:17 2011 -0800
@@ -120,7 +120,7 @@
 			[chat setValue:invitationMessage forProperty:@"InitialInivitationMessage" notify:NotifyNever];
 		}
 		
-		[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(chatDidOpen:) name:Chat_DidOpen object:chat];
+		[[NSNotificationCenter defaultCenter] addObserver:[self retain] selector:@selector(chatDidOpen:) name:Chat_DidOpen object:chat];
 	}
 	
 }
@@ -155,6 +155,7 @@
 	
 	//We are no longer concerned with the opening of this chat.
 	[[NSNotificationCenter defaultCenter] removeObserver:self name:Chat_DidOpen object:chat];
+	[self release];
 }
 
 /*!




More information about the commits mailing list