adium-1.4 3629:354e4828e888: This now indicates a simple leak; q...

commits at adium.im commits at adium.im
Mon Aug 29 00:17:52 UTC 2011


details:	http://hg.adium.im/adium-1.4/rev/354e4828e888
revision:	3629:354e4828e888
branch:		(none)
author:		Evan Schoenberg
date:		Sun Aug 28 19:17:33 2011 -0500

This now indicates a simple leak; quiet it down and move it into our debug logging
(transplanted from 2fb1b4da6e8728c51887213164f3f3eb39bfa6d1)

diffs (19 lines):

diff -r b702c5f10d91 -r 354e4828e888 Frameworks/Adium Framework/Source/AIProxyListObject.m
--- a/Frameworks/Adium Framework/Source/AIProxyListObject.m	Sat Aug 27 21:03:18 2011 +0200
+++ b/Frameworks/Adium Framework/Source/AIProxyListObject.m	Sun Aug 28 19:17:33 2011 -0500
@@ -48,10 +48,11 @@
 	proxy = [proxyDict objectForKey:key];
 
 	if (proxy && proxy.listObject != inListObject) {
-        /* This is a cataclysmic memory management failure and should NEVER happen. I leave the logging in for now. -evands 8/7/11 */
-		NSLog(@"Re-used AIProxyListObject (this should not happen.). Key %@ for inListObject %@ -> %p.listObject=%@", key,inListObject,proxy,proxy.listObject);
-		[self releaseProxyObject:proxy];
-		proxy = nil;
+        /* This is a memory management failure; AIContactController stopped tracking a list object, but it never deallocated. -evands 8/7/11 */
+		AILogWithSignature(@"%@ was leaked! Meh.", proxy.listObject);
+
+		proxy.listObject = inListObject;
+		proxy.containingObject = inContainingObject;
 	}
 
 	if (!proxy) {




More information about the commits mailing list