adium 4179:3cb7433b3d90: Patch from kbotc which fixes a leak wit...

commits at adium.im commits at adium.im
Tue Aug 23 19:38:21 UTC 2011


details:	http://hg.adium.im/adium/rev/3cb7433b3d90
revision:	4179:3cb7433b3d90
branch:		(none)
author:		Thijs Alkemade <thijsalkemade at gmail.com>
date:		Tue Aug 23 21:37:53 2011 +0200

Patch from kbotc which fixes a leak with Status.net.

diffs (52 lines):

diff -r 6091a858e33c -r 3cb7433b3d90 Plugins/Twitter Plugin/AILaconicaAccount.m
--- a/Plugins/Twitter Plugin/AILaconicaAccount.m	Mon Aug 22 21:11:40 2011 -0500
+++ b/Plugins/Twitter Plugin/AILaconicaAccount.m	Tue Aug 23 21:37:53 2011 +0200
@@ -31,6 +31,8 @@
 - (void)initAccount
 {
 	[super initAccount];
+	textLimitConfigDownload = nil;
+	configData = nil;
 	[adium.preferenceController registerDefaults:[NSDictionary dictionaryWithObjectsAndKeys:
 												  [NSNumber numberWithBool:YES], LACONICA_PREFERENCE_SSL, nil]
 										forGroup:LACONICA_PREF_GROUP
@@ -178,7 +180,7 @@
 -(void)connectionDidFinishLoading:(NSURLConnection *)connection
 {
     if ([connection isEqual:textLimitConfigDownload]) {
-        NSError         *err=nil;
+        NSError         *err = nil;
         NSXMLDocument   *config = [[NSXMLDocument alloc] initWithData:configData
                                                               options:0
                                                                 error:&err];
@@ -194,6 +196,9 @@
         
         if (err != nil)
             AILogWithSignature(@"Failed fetching StatusNet server config for %@: %d %@", self.host, [err code], [err localizedDescription]);
+	
+		[configData release]; configData = nil;
+		[textLimitConfigDownload release]; textLimitConfigDownload = nil;
     }
 }
 
@@ -204,8 +209,7 @@
 {
     [textLimitConfigDownload release]; textLimitConfigDownload = nil;
     
-    [configData release];
-    configData = nil;
+    [configData release]; configData = nil;
     
     AILogWithSignature(@"%@",[NSString stringWithFormat:@"Fetch failed: %@", [error localizedDescription]]);
 }
diff -r 6091a858e33c -r 3cb7433b3d90 Plugins/Twitter Plugin/AITwitterAccount.m
--- a/Plugins/Twitter Plugin/AITwitterAccount.m	Mon Aug 22 21:11:40 2011 -0500
+++ b/Plugins/Twitter Plugin/AITwitterAccount.m	Tue Aug 23 21:37:53 2011 +0200
@@ -1136,6 +1136,7 @@
 						  withDictionary:[NSDictionary dictionaryWithObject:[NSNumber numberWithInt:1] forKey:friendRequestType]];
 				}
 			} else {
+				[[self timelineChat] removeAllParticipatingContactsSilently];
 				[self removeAllContacts];
 			}
 		}




More information about the commits mailing list