adium-1.4 3176:08c3c8460e3c: Narrow the scope of this change to ...
commits at adium.im
commits at adium.im
Sat Oct 30 09:35:32 UTC 2010
details: http://hg.adium.im/adium-1.4/rev/08c3c8460e3c
revision: 3176:08c3c8460e3c
author: Evan Schoenberg
date: Sat Oct 30 04:34:46 2010 -0500
Narrow the scope of this change to reduce possible bugs; only set the delegate if it's a contact menu and it's to laod lazily
diffs (29 lines):
diff -r 341da2daf2cb -r 08c3c8460e3c Frameworks/Adium Framework/Source/AIAbstractListObjectMenu.m
--- a/Frameworks/Adium Framework/Source/AIAbstractListObjectMenu.m Sat Oct 30 04:13:17 2010 -0500
+++ b/Frameworks/Adium Framework/Source/AIAbstractListObjectMenu.m Sat Oct 30 04:34:46 2010 -0500
@@ -71,7 +71,6 @@
{
if(!menu) {
menu = [[NSMenu allocWithZone:[NSMenu zone]] init];
- [menu setDelegate:self];
[menu setMenuChangedMessagesEnabled:NO];
for (NSMenuItem *menuItem in self.menuItems)
diff -r 341da2daf2cb -r 08c3c8460e3c Frameworks/Adium Framework/Source/AIContactMenu.m
--- a/Frameworks/Adium Framework/Source/AIContactMenu.m Sat Oct 30 04:13:17 2010 -0500
+++ b/Frameworks/Adium Framework/Source/AIContactMenu.m Sat Oct 30 04:34:46 2010 -0500
@@ -143,6 +143,14 @@
return delegate;
}
+- (NSMenu *)menu
+{
+ NSMenu *theMenu = [super menu];
+ if (populateMenuLazily)
+ [theMenu setDelegate:self];
+ return theMenu;
+}
+
/*!
* @brief Inform our delegate when the menu is rebuilt
*/
More information about the commits
mailing list