adium 3447:9d074a461a19: Cleanup, remove debug logging, remove s...

commits at adium.im commits at adium.im
Sat Oct 30 09:14:06 UTC 2010


details:	http://hg.adium.im/adium/rev/9d074a461a19
revision:	3447:9d074a461a19
author:		Evan Schoenberg
date:		Sat Oct 30 04:13:17 2010 -0500

Cleanup, remove debug logging, remove stray release
(transplanted from 341da2daf2cb8bf8f2a0a89f41d891821c976017)

diffs (46 lines):

diff -r 1818acad1728 -r 9d074a461a19 Plugins/Status Menu Item/CBStatusMenuItemController.m
--- a/Plugins/Status Menu Item/CBStatusMenuItemController.m	Sat Oct 30 03:53:55 2010 -0500
+++ b/Plugins/Status Menu Item/CBStatusMenuItemController.m	Sat Oct 30 04:13:17 2010 -0500
@@ -104,10 +104,10 @@
 		accountsMenuNeedsUpdate = YES;
 		optionsMenuNeedsUpdate = YES;
 		
-		self.contactsMenuItem = [[NSMenuItem allocWithZone:[NSMenu menuZone]] initWithTitle:AILocalizedString(@"Contacts",nil)
-																					 target:self
-																					 action:nil
-																			  keyEquivalent:@""];
+		self.contactsMenuItem = [[[NSMenuItem allocWithZone:[NSMenu menuZone]] initWithTitle:AILocalizedString(@"Contacts",nil)
+																					  target:self
+																					  action:nil
+																			   keyEquivalent:@""] autorelease];
 
 		NSNotificationCenter *notificationCenter = [NSNotificationCenter defaultCenter];
 		//Register to recieve chat opened and chat closed notifications
@@ -523,7 +523,6 @@
 - (void)contactMenuDidRebuild:(AIContactMenu *)inContactMenu 
 {
 	NSMenu *menu = inContactMenu.menu;
-
 	NSInteger newNumberOfMenuItems = menu.numberOfItems;
 
 	// Going from or to 0 contacts requires a main menu update
@@ -603,6 +602,11 @@
 	return YES;
 }
 
+- (BOOL)contactMenuShouldPopulateMenuLazily:(AIContactMenu *)inContactMenu
+{
+	return YES;
+}
+
 #pragma mark List Object Observer
 /*!
  * @brief List Observer delegate method
@@ -709,7 +713,6 @@
 		if ([contactMenu.menu numberOfItems] > 0) {
 			// Add contacts
 			[menu addItem:self.contactsMenuItem];
-			[menuItem release];
 
 		} else {
 			[menu addItemWithTitle:[AILocalizedString(@"Contact List", nil) stringByAppendingEllipsis]




More information about the commits mailing list