adium 3374:ec636ee7427a: Enable the retweet link by default (doe...

[commits at adium.im]

details:	http://hg.adium.im/adium/rev/ec636ee7427a
revision:	3374:ec636ee7427a
author:		Evan Schoenberg
date:		Mon Oct 18 00:54:37 2010 -0500

Enable the retweet link by default (does this really need to be a preference at all?) and added a code comment.
(transplanted from 6e8f5a4ded8ade1178fec8e0dbe497c14657a0f6)

diffs (24 lines):

diff -r dcdf6a2503cc -r ec636ee7427a Plugins/Twitter Plugin/AITwitterAccount.m
--- a/Plugins/Twitter Plugin/AITwitterAccount.m	Sun Oct 17 22:55:16 2010 -0500
+++ b/Plugins/Twitter Plugin/AITwitterAccount.m	Mon Oct 18 00:54:37 2010 -0500
@@ -95,6 +95,7 @@
 	[adium.preferenceController registerDefaults:[NSDictionary dictionaryWithObjectsAndKeys:
 												  [NSNumber numberWithInt:TWITTER_UPDATE_INTERVAL_MINUTES], TWITTER_PREFERENCE_UPDATE_INTERVAL,
 												  [NSNumber numberWithBool:YES], TWITTER_PREFERENCE_UPDATE_AFTER_SEND,
+												  [NSNumber numberWithBool:YES], TWITTER_PREFERENCE_RETWEET_SPAM,
 												  [NSNumber numberWithBool:YES], TWITTER_PREFERENCE_LOAD_CONTACTS, nil]
 										forGroup:TWITTER_PREFERENCE_GROUP_UPDATES
 										  object:self];
@@ -160,6 +161,12 @@
 	
 	if (self.useOAuth) {
 		if (!self.passwordWhileConnected.length) {
+			/* If we weren't able to retrieve the 'password', we can't proceed with oauth - we stored the oauth
+			 * http response body in the keychain as the password.
+			 *
+			 * Note that this can happen not only if Adium isn't authorized but also if it *is* authorized but the
+			 * keychain was inaccessible - e.g. keychain access wasn't allowed after an upgrade. Hm.
+			 */
 			[self setLastDisconnectionError:TWITTER_OAUTH_NOT_AUTHORIZED];
 			
 			[[NSNotificationCenter defaultCenter] postNotificationName:@"AIEditAccount"