adium-1.4 3229:3429fa3628c5: Fixed contact status background col...

commits at adium.im commits at adium.im
Wed Nov 10 04:55:32 UTC 2010


details:	http://hg.adium.im/adium-1.4/rev/3429fa3628c5
revision:	3229:3429fa3628c5
author:		Evan Schoenberg
date:		Tue Nov 09 22:54:34 2010 -0600

Fixed contact status background colors updating in the contact list, including both static and flashing statuses. Fixes #14534. Fixes #14493.
Subject: adium-1.4 3230:62545038e5ea: Noted that this is private API for posting notifications

details:	http://hg.adium.im/adium-1.4/rev/62545038e5ea
revision:	3230:62545038e5ea
author:		Evan Schoenberg
date:		Tue Nov 09 22:55:17 2010 -0600

Noted that this is private API for posting notifications

diffs (41 lines):

diff -r 1ec859f7bb8c -r 62545038e5ea Frameworks/Adium Framework/Source/AIContactControllerProtocol.h
--- a/Frameworks/Adium Framework/Source/AIContactControllerProtocol.h	Tue Nov 09 01:24:07 2010 -0500
+++ b/Frameworks/Adium Framework/Source/AIContactControllerProtocol.h	Tue Nov 09 22:55:17 2010 -0600
@@ -11,11 +11,13 @@
 @class AIListObject, AIListContact, AIChat;
 @protocol AIContainingObject;
 
-/* Posted for a single object whose attributes changed */
+/* Posted for a single object whose attributes changed.
+ * Must be used for observing only! Only the contact controller should post this notification. */
 #define ListObject_AttributesChanged			@"ListObject_AttributesChanged"
 
 /* Called when one or more ListObject_AttributesChanged notifications are done and all delays have cleared.
- * We're ready to update the display at this point. */
+ * We're ready to update the display at this point.
+ * Must be used for observing only! Only the contact controller should post this notification. */
 #define ListObject_AttributeChangesComplete			@"ListObject_AttributeChangesComplete"
 
 #define ListObject_StatusChanged				@"ListObject_StatusChanged"
diff -r 1ec859f7bb8c -r 62545038e5ea Source/AIContactStatusColoringPlugin.m
--- a/Source/AIContactStatusColoringPlugin.m	Tue Nov 09 01:24:07 2010 -0500
+++ b/Source/AIContactStatusColoringPlugin.m	Tue Nov 09 22:55:17 2010 -0600
@@ -248,13 +248,13 @@
 {
     AIListContact	*object;
 
+	NSSet *modifiedKeys = [NSSet setWithObjects:@"Text Color", @"Label Color", @"Inverted Text Color", nil];
+
     for (object in flashingListObjects) {
         [self _applyColorToContact:object];
-        
-        //Force a redraw
-        [[NSNotificationCenter defaultCenter] postNotificationName:ListObject_AttributesChanged 
-												  object:object
-												userInfo:[NSDictionary dictionaryWithObject:[NSArray arrayWithObjects:@"Text Color", @"Label Color", @"Inverted Text Color", nil] forKey:@"Keys"]];
+    
+		[[AIContactObserverManager sharedManager] listObjectAttributesChanged:object
+																 modifiedKeys:modifiedKeys];
     }
 }
 




More information about the commits mailing list