adium 3148:f8cfc0c842f4: Expanded documentation on -[AIAccount c...

[commits at adium.im]

details:	http://hg.adium.im/adium/rev/f8cfc0c842f4
revision:	3148:f8cfc0c842f4
author:		Evan Schoenberg
date:		Sat Mar 13 20:10:55 2010 -0600

Expanded documentation on -[AIAccount contactListEditable]
Subject: adium 3149:cc87543b961d: Stubbed out contact moving management in Bonjour; Bonjour will need to do its own store of appropriate 'serverside' grouping

details:	http://hg.adium.im/adium/rev/cc87543b961d
revision:	3149:cc87543b961d
author:		Evan Schoenberg
date:		Sat Mar 13 20:11:35 2010 -0600

Stubbed out contact moving management in Bonjour; Bonjour will need to do its own store of appropriate 'serverside' grouping
Subject: adium 3150:59fcacd5df25: Disable Facebook friend management, turning off that authorization request window for Faceboook entirely. This also prevents accidental deletion of Facebook friends from your list - it's not obvious to me, at least, that a deletion in Adium would completely remove the friend on Facebook. Fixes #13504

details:	http://hg.adium.im/adium/rev/59fcacd5df25
revision:	3150:59fcacd5df25
author:		Evan Schoenberg
date:		Sat Mar 13 20:09:47 2010 -0600

Disable Facebook friend management, turning off that authorization request window for Faceboook entirely. This also prevents accidental deletion of Facebook friends from your list - it's not obvious to me, at least, that a deletion in Adium would completely remove the friend on Facebook. Fixes #13504
(transplanted from c11f47c1113f1eb2c67fcafbcb3161ff9092f66e)

diffs (63 lines):

diff -r 7c30672e8e1c -r 59fcacd5df25 Frameworks/Adium Framework/Source/AIAccount.m
--- a/Frameworks/Adium Framework/Source/AIAccount.m	Sat Mar 13 19:55:50 2010 -0600
+++ b/Frameworks/Adium Framework/Source/AIAccount.m	Sat Mar 13 20:09:47 2010 -0600
@@ -707,6 +707,9 @@
 /*!
  * @brief Contact list editable?
  *
+ * Editable means contacts can be added or removed.  Contacts should always be able to be moved between groups.
+ * The account may have to implement its own grouping store if a serverside store does not exist.
+ *
  * @return YES if the contact list is currently editable
  */
 - (BOOL)contactListEditable
diff -r 7c30672e8e1c -r 59fcacd5df25 Plugins/Bonjour/AWBonjourAccount.m
--- a/Plugins/Bonjour/AWBonjourAccount.m	Sat Mar 13 19:55:50 2010 -0600
+++ b/Plugins/Bonjour/AWBonjourAccount.m	Sat Mar 13 20:09:47 2010 -0600
@@ -600,4 +600,25 @@
 	[[ESFileTransfer existingFileTransferWithID:[transfer uniqueID]] setStatus:Complete_FileTransfer];
 }
 
+#pragma mark Contact list management
+- (void)moveListObjects:(NSArray *)objects fromGroups:(NSSet *)oldGroups toGroups:(NSSet *)groups
+{	
+	//Move the objects to it
+	for (AIListContact *contact in objects) {
+		if (![contact.remoteGroups intersectsSet:oldGroups] && oldGroups.count) {
+			continue;
+		}
+		
+		/* 
+		for (AIListGroup *group in oldGroups) {
+			[contact removeRemoteGroupName:group.UID];
+		}
+		
+		for (AIListGroup *group in groups) {
+			[contact addRemoteGroupName:group.UID];
+		}
+		 */
+	}		
+}
+
 @end
diff -r 7c30672e8e1c -r 59fcacd5df25 Plugins/Purple Service/PurpleFacebookAccount.m
--- a/Plugins/Purple Service/PurpleFacebookAccount.m	Sat Mar 13 19:55:50 2010 -0600
+++ b/Plugins/Purple Service/PurpleFacebookAccount.m	Sat Mar 13 20:09:47 2010 -0600
@@ -37,11 +37,14 @@
 	// We do our own history; don't let the server's history get displayed as new messages
 	purple_account_set_bool(account, "facebook_show_history", FALSE);
 	
-	// Use friends list as groups.
+	// Use friends list as groups. This also allows moving between groups through libpurple
 	purple_account_set_bool(account, "facebook_use_groups", TRUE);
 	
-	// Allow for moving through libpurple
-	purple_account_set_bool(account, "facebook_manage_friends", TRUE);
+	/* Don't prompt for authorization. Don't delete friends from the Facebook friend list,
+	 * as doing so is not a clear way to remove the friend entirely but that's what would
+	 * happen. Adding friends isn't supported, anyways.
+	 */
+	purple_account_set_bool(account, "facebook_manage_friends", FALSE);
 	
 	// Disable the Facebook CAPTCHA since it causes heartache and pain.
 	purple_account_set_bool(account, "ignore-facebook-captcha", TRUE);