adium 3146:ecebac82abed: None of these things require cookies. N...

commits at adium.im commits at adium.im
Mon Mar 1 19:04:13 UTC 2010


details:	http://hg.adium.im/adium/rev/ecebac82abed
revision:	3146:ecebac82abed
author:		Stephen Holt <sholt at adium.im>
date:		Mon Mar 01 14:04:01 2010 -0500

None of these things require cookies. Not even twitter.

diffs (72 lines):

diff -r ce4a2a182037 -r ecebac82abed Plugins/Bonjour/libezv/Classes/EKEzvIncomingFileTransfer.m
--- a/Plugins/Bonjour/libezv/Classes/EKEzvIncomingFileTransfer.m	Mon Mar 01 11:06:59 2010 -0500
+++ b/Plugins/Bonjour/libezv/Classes/EKEzvIncomingFileTransfer.m	Mon Mar 01 14:04:01 2010 -0500
@@ -285,6 +285,7 @@
 	NSMutableURLRequest *theRequest=[NSMutableURLRequest requestWithURL:downloadURL cachePolicy:NSURLRequestUseProtocolCachePolicy timeoutInterval:60.0];
 	NSString *value = [NSString stringWithString:@"AppleSingle"];
 	[theRequest addValue:value forHTTPHeaderField:@"Accept-Encoding"];
+	[theRequest setHTTPShouldHandleCookies:NO];
 
 	// create the connection with the request
 	// and start loading the data
diff -r ce4a2a182037 -r ecebac82abed Plugins/Twitter Plugin/AITwitterStatusFollowup.m
--- a/Plugins/Twitter Plugin/AITwitterStatusFollowup.m	Mon Mar 01 11:06:59 2010 -0500
+++ b/Plugins/Twitter Plugin/AITwitterStatusFollowup.m	Mon Mar 01 14:04:01 2010 -0500
@@ -111,7 +111,9 @@
 	[url appendFormat:@"&username=%@", username];
 	[url appendFormat:@"&network=%@", network];
 	
-	NSURLConnection *connection = [NSURLConnection connectionWithRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:url]]
+	NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:[NSURL URLWithString:url]];
+	[request setHTTPShouldHandleCookies:NO];
+	NSURLConnection *connection = [NSURLConnection connectionWithRequest:request
 																delegate:self];
 	
 	// We don't implement any delegate methods, because if this fails we don't bother retrying.
diff -r ce4a2a182037 -r ecebac82abed Plugins/Twitter Plugin/MGTwitterEngine/MGTwitterEngine.m
--- a/Plugins/Twitter Plugin/MGTwitterEngine/MGTwitterEngine.m	Mon Mar 01 11:06:59 2010 -0500
+++ b/Plugins/Twitter Plugin/MGTwitterEngine/MGTwitterEngine.m	Mon Mar 01 14:04:01 2010 -0500
@@ -359,6 +359,7 @@
     NSMutableURLRequest *theRequest = [NSMutableURLRequest requestWithURL:url 
                                                               cachePolicy:NSURLRequestReloadIgnoringCacheData 
                                                           timeoutInterval:URL_REQUEST_TIMEOUT];
+	[theRequest setHTTPShouldHandleCookies:NO];
     
     // Create a connection using this request, with the default timeout and caching policy, 
     // and appropriate Twitter request and response types for parsing and error reporting.
@@ -418,6 +419,7 @@
     NSMutableURLRequest *theRequest = [NSMutableURLRequest requestWithURL:finalURL 
                                                               cachePolicy:NSURLRequestReloadIgnoringCacheData 
                                                           timeoutInterval:URL_REQUEST_TIMEOUT];
+	[theRequest setHTTPShouldHandleCookies:NO];
 	if(method && [method isEqualToString:HTTP_MULTIPART_METHOD]) {
 		method = HTTP_POST_METHOD;
 		[theRequest setValue:[NSString stringWithFormat:@"multipart/form-data; boundary=%@", MULTIPART_FORM_BOUNDARY] forHTTPHeaderField:@"Content-type"];
diff -r ce4a2a182037 -r ecebac82abed Source/AIURLShortenerPlugin.m
--- a/Source/AIURLShortenerPlugin.m	Mon Mar 01 11:06:59 2010 -0500
+++ b/Source/AIURLShortenerPlugin.m	Mon Mar 01 14:04:01 2010 -0500
@@ -319,7 +319,9 @@
 	
 	// We send a synchronous request so the user can't change selection on us.
 	// If the target site is slow, this may seem unpleasant.
-	NSData	*shortenedData = [NSURLConnection sendSynchronousRequest:[NSURLRequest requestWithURL:inURL]
+	NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:inURL];
+	[request setHTTPShouldHandleCookies:NO];
+	NSData	*shortenedData = [NSURLConnection sendSynchronousRequest:request
 												  returningResponse:&response
 															  error:&errorResponse];
 	
diff -r ce4a2a182037 -r ecebac82abed Source/XtrasInstaller.m
--- a/Source/XtrasInstaller.m	Mon Mar 01 11:06:59 2010 -0500
+++ b/Source/XtrasInstaller.m	Mon Mar 01 14:04:01 2010 -0500
@@ -98,7 +98,9 @@
 													   ([url query] ? [url query] : @"")]];
 //		dest = [NSTemporaryDirectory() stringByAppendingPathComponent:[[urlToDownload path] lastPathComponent]];
 		AILogWithSignature(@"Downloading %@", urlToDownload);
-		download = [[NSURLDownload alloc] initWithRequest:[NSURLRequest requestWithURL:urlToDownload] delegate:self];
+		NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:urlToDownload];
+		[request setHTTPShouldHandleCookies:NO];
+		download = [[NSURLDownload alloc] initWithRequest:request delegate:self];
 //		[download setDestination:dest allowOverwrite:YES];
 
 		[urlToDownload release];




More information about the commits mailing list