adium 3139:100c1b828c9f: It might be nice to release these opera...

commits at adium.im commits at adium.im
Wed Feb 24 20:43:32 UTC 2010


details:	http://hg.adium.im/adium/rev/100c1b828c9f
revision:	3139:100c1b828c9f
author:		Stephen Holt <sholt at adium.im>
date:		Wed Feb 24 14:12:12 2010 -0500

It might be nice to release these operations...

diffs (54 lines):

diff -r 929a9b48b25e -r 100c1b828c9f Source/AILoggerPlugin.m
--- a/Source/AILoggerPlugin.m	Mon Feb 08 15:58:53 2010 -0800
+++ b/Source/AILoggerPlugin.m	Wed Feb 24 14:12:12 2010 -0500
@@ -450,9 +450,9 @@
 {
 	[AILogViewerWindowController openForContact:nil plugin:self];
 	[[[self class] operationQueue] addOperation:
-	 [[NSInvocationOperation alloc] initWithTarget:self
+	 [[[NSInvocationOperation alloc] initWithTarget:self
 																				selector:@selector(dirtyAllLogs)
-																					object:nil]];
+																					object:nil] autorelease]];
 }
 
 /*!
@@ -1121,8 +1121,8 @@
 																								object:nil];
 	}
 	[op addDependency:indexOp];
-	[[[self class] operationQueue] addOperation:indexOp];
-	[[[self class] operationQueue] addOperation:op];
+	[[[self class] operationQueue] addOperation:[indexOp autorelease]];
+	[[[self class] operationQueue] addOperation:[op autorelease]];
 }
 
 //Close down and clean up the log index  (Call when finished using the logSearchIndex)
@@ -1131,9 +1131,9 @@
 	indexingAllowed = NO;
 	[[[self class] operationQueue] cancelAllOperations];
 	[[[self class] operationQueue] addOperation:
-	 [[NSInvocationOperation alloc] initWithTarget:self
+	 [[[NSInvocationOperation alloc] initWithTarget:self
 																				selector:@selector(closeLogIndex)
-																					object:nil]];
+																					object:nil] autorelease]];
 }
 
 //Returns the Search Kit index for log content searching
@@ -1634,13 +1634,13 @@
 
 - (void)removePathsFromIndex:(NSSet *)paths
 {
-	[[AILoggerPlugin operationQueue] addOperation:[[NSInvocationOperation alloc]
+	[[AILoggerPlugin operationQueue] addOperation:[[[NSInvocationOperation alloc]
 												   initWithTarget:self
 												   selector:@selector(_removePathsFromIndexThread:)
 												   object:[NSDictionary dictionaryWithObjectsAndKeys:
 														   (id)[self logContentIndex], @"SKIndexRef",
 														   paths, @"Paths",
-														   nil]]];
+														   nil]] autorelease]];
 }
 
 




More information about the commits mailing list