adium 3105:e864e707fb51: Hey! I've got a great idea, let's not ...
commits at adium.im
commits at adium.im
Thu Feb 4 03:07:41 UTC 2010
details: http://hg.adium.im/adium/rev/e864e707fb51
revision: 3105:e864e707fb51
author: Stephen Holt <sholt at adium.im>
date: Wed Feb 03 22:06:53 2010 -0500
Hey! I've got a great idea, let's not check a returned BOOL value to see if we should return YES or NO! *facepalm*
diffs (35 lines):
diff -r 45c784536ad3 -r e864e707fb51 Frameworks/AutoHyperlinks Framework/Source/AHMarkedHyperlink.m
--- a/Frameworks/AutoHyperlinks Framework/Source/AHMarkedHyperlink.m Wed Feb 03 22:00:03 2010 -0500
+++ b/Frameworks/AutoHyperlinks Framework/Source/AHMarkedHyperlink.m Wed Feb 03 22:06:53 2010 -0500
@@ -132,9 +132,9 @@
- (BOOL)doesContain:(id)object
{
if([object isKindOfClass:[NSURL class]])
- return [(NSURL *)object isEqualTo:self.URL]? YES : NO;
+ return [(NSURL *)object isEqualTo:self.URL];
if([object isKindOfClass:[NSString class]])
- return [(NSString *)object isEqualTo:self.parentString]? YES : NO;
+ return [(NSString *)object isEqualTo:self.parentString];
return NO;
}
@@ -167,16 +167,16 @@
{
if([object isKindOfClass:[AHMarkedHyperlink class]])
return [[((AHMarkedHyperlink *)object).parentString substringWithRange:((AHMarkedHyperlink *)object).range]
- isGreaterThan:[self.parentString substringWithRange:self.range]]? YES : NO;
+ isGreaterThan:[self.parentString substringWithRange:self.range]];
return NO;
}
- (BOOL)isLessThan:(id)object
{
if([object isKindOfClass:[NSURL class]])
- return [(NSURL *)object isLessThan:self.URL]? YES : NO;
+ return [(NSURL *)object isLessThan:self.URL];
if([object isKindOfClass:[NSString class]])
- return [(NSString *)object isLessThan:self.parentString]? YES : NO;
+ return [(NSString *)object isLessThan:self.parentString];
return NO;
}
More information about the commits
mailing list