adium-1.4 2925:acdf1d72ebcb: If no password is set, use NULL, no...

commits at adium.im commits at adium.im
Tue Apr 27 16:09:58 UTC 2010


details:	http://hg.adium.im/adium-1.4/rev/acdf1d72ebcb
revision:	2925:acdf1d72ebcb
author:		Evan Schoenberg
date:		Tue Apr 27 11:09:33 2010 -0500

If no password is set, use NULL, not "", as the password to send libpurple, as code in various places checks for NULL rather than a 0-length string.  This, in turn, fixes prompting for the password if no password is entered for a Jabber account which needs one. The form-based request is ugly, but at least now it's functional.
(transplanted from bd12f98a66c31a0b5207303be6e02e1efced9724)

diffs (12 lines):

diff -r 90cc6e5031bb -r acdf1d72ebcb Plugins/Purple Service/CBPurpleAccount.m
--- a/Plugins/Purple Service/CBPurpleAccount.m	Mon Apr 26 20:14:11 2010 -0500
+++ b/Plugins/Purple Service/CBPurpleAccount.m	Tue Apr 27 11:09:33 2010 -0500
@@ -1827,7 +1827,7 @@
 - (void)continueConnectWithConfiguredProxy
 {
 	//Set password and connect
-	purple_account_set_password(account, [password UTF8String]);
+	purple_account_set_password(account, ([password length] ? [password UTF8String] : NULL));
 
 	//Set our current status state after filtering its statusMessage as appropriate. This will take us online in the process.
 	AIStatus	*statusState = [self valueForProperty:@"StatusState"];




More information about the commits mailing list