adium 2683:e90ef7557b4a: Fixed crash when changing notification ...

commits at adium.im commits at adium.im
Fri Sep 4 23:55:59 UTC 2009


details:	http://hg.adium.im/adium/rev/e90ef7557b4a
revision:	2683:e90ef7557b4a
author:		Aaron at macbook-pro.local
date:		Fri Sep 04 16:26:39 2009 -0700

Fixed crash when changing notification volume level in preferences.  Fixes #12965.

Reviewed by Stephen Holt, slightly modified for efficency.

diffs (31 lines):

diff -r e18ba043e821 -r e90ef7557b4a Copyright.txt
--- a/Copyright.txt	Thu Sep 03 16:59:46 2009 -0400
+++ b/Copyright.txt	Fri Sep 04 16:26:39 2009 -0700
@@ -75,5 +75,6 @@
 Ngan Pham
 Jay Weatherstone
 Robby Weinberg
+Aaron Dodson
 
 If you have contributed to Adium and are not on this list, please contact us.
diff -r e18ba043e821 -r e90ef7557b4a Source/AdiumSound.m
--- a/Source/AdiumSound.m	Thu Sep 03 16:59:46 2009 -0400
+++ b/Source/AdiumSound.m	Fri Sep 04 16:26:39 2009 -0700
@@ -178,15 +178,9 @@
  */
 - (void)_setVolumeOfAllSoundsTo:(CGFloat)inVolume
 {
-#ifdef __LP64__
-	for(NSSound *sound in soundCacheDict) {
-		[sound setVolume:inVolume];
+	for(id sound in  [soundCacheDict allValues]) {
+		[(NSSound *)sound setVolume:inVolume];
 	}
-#else
-	for(QTMovie *movie in soundCacheDict) {
-		[movie setVolume:inVolume];
-	}
-#endif
 }
 
 /*!




More information about the commits mailing list