adium-1.4 2673:bc795bf3add5: Fix a number of leaks in AIAppearan...

commits at adium.im commits at adium.im
Wed Oct 28 21:32:11 UTC 2009


details:	http://hg.adium.im/adium-1.4/rev/bc795bf3add5
revision:	2673:bc795bf3add5
author:		Stephen Holt <sholt at adium.im>
date:		Wed Oct 28 16:46:55 2009 -0400

Fix a number of leaks in AIAppearancePreferences

diffs (57 lines):

diff -r 8b6bc0d80b65 -r bc795bf3add5 Source/AIAppearancePreferences.m
--- a/Source/AIAppearancePreferences.m	Wed Oct 28 15:41:29 2009 -0400
+++ b/Source/AIAppearancePreferences.m	Wed Oct 28 16:46:55 2009 -0400
@@ -833,7 +833,7 @@
 															  keyEquivalent:@""] autorelease];
 	[menu addItem:menuItem];
 	
-	return menu;	
+	return [menu autorelease];	
 }
 
 /*!
@@ -874,7 +874,7 @@
 															  keyEquivalent:@""] autorelease];
 	[menu addItem:menuItem];
 	
-	return menu;	
+	return [menu autorelease];	
 }
 
 
@@ -942,7 +942,7 @@
  */
 - (void)configureDockIconMenu
 {
-	NSMenu		*tempMenu = [[NSMenu allocWithZone:[NSMenu menuZone]] init];
+	NSMenu		*tempMenu = [[[NSMenu allocWithZone:[NSMenu menuZone]] init] autorelease];
 	NSString	*iconPath;
 	NSString	*activePackName = [adium.preferenceController preferenceForKey:KEY_ACTIVE_DOCK_ICON
 																		   group:PREF_GROUP_APPEARANCE];
@@ -995,7 +995,7 @@
 
 - (void)configureStatusIconsMenu
 {
-	NSMenu		*tempMenu = [[NSMenu allocWithZone:[NSMenu menuZone]] init];
+	NSMenu		*tempMenu = [[[NSMenu allocWithZone:[NSMenu menuZone]] init] autorelease];
 	NSString	*iconPath;
 	NSString	*activePackName = [adium.preferenceController preferenceForKey:KEY_STATUS_ICON_PACK
 																		   group:PREF_GROUP_APPEARANCE];
@@ -1022,7 +1022,7 @@
 
 - (void)configureServiceIconsMenu
 {
-	NSMenu		*tempMenu = [[NSMenu allocWithZone:[NSMenu menuZone]] init];
+	NSMenu		*tempMenu = [[[NSMenu allocWithZone:[NSMenu menuZone]] init] autorelease];
 	NSString	*iconPath;
 	NSString	*activePackName = [adium.preferenceController preferenceForKey:KEY_SERVICE_ICON_PACK
 																		   group:PREF_GROUP_APPEARANCE];
@@ -1049,7 +1049,7 @@
 
 - (void)configureMenuBarIconsMenu
 {
-	NSMenu		*tempMenu = [[NSMenu allocWithZone:[NSMenu menuZone]] init];
+	NSMenu		*tempMenu = [[[NSMenu allocWithZone:[NSMenu menuZone]] init] autorelease];
 	NSString	*iconPath;
 	NSString	*activePackName = [adium.preferenceController preferenceForKey:KEY_MENU_BAR_ICONS
 																		   group:PREF_GROUP_APPEARANCE];




More information about the commits mailing list