adium 2359:805e6f9d8ad3: As it turns out, the sliders were way o...

commits at adium.im commits at adium.im
Thu May 28 04:23:26 UTC 2009


details:	http://hg.adium.im/adium/rev/805e6f9d8ad3
revision:	2359:805e6f9d8ad3
author:		Peter Hosey <hg at boredzo.org>
date:		Wed May 27 21:05:17 2009 -0700

As it turns out, the sliders were way out of range anyway: [http://developer.apple.com/documentation/mac/Sound/Sound-190.html#MARKER-2-95 Speech Manager's range for the pitch base was 0–100]. Increasing the sliders' new max values to match. Also changing the default values to 43.34766, which is the default pitch base of Alex, the default voice.

This does mean that the default value is no longer dead center on the slider; sad, but having the correct default pitch for the default voice is more important.

Refs #12251.

diffstat:

 Resources/AnnouncerSpeakEventContactAlert.nib/keyedobjects.nib |     
 Resources/AnnouncerSpeakTextContactAlert.nib/classes.nib       |  16 ++++----
 Resources/AnnouncerSpeakTextContactAlert.nib/keyedobjects.nib  |     
 Source/AdiumSpeech.m                                           |   1 +
 4 files changed, 9 insertions(+), 8 deletions(-)

diffs (48 lines):

diff -r 7981f03cce51 -r 805e6f9d8ad3 Resources/AnnouncerSpeakEventContactAlert.nib/keyedobjects.nib
Binary file Resources/AnnouncerSpeakEventContactAlert.nib/keyedobjects.nib has changed
diff -r 7981f03cce51 -r 805e6f9d8ad3 Resources/AnnouncerSpeakTextContactAlert.nib/classes.nib
--- a/Resources/AnnouncerSpeakTextContactAlert.nib/classes.nib	Thu May 28 00:20:01 2009 -0400
+++ b/Resources/AnnouncerSpeakTextContactAlert.nib/classes.nib	Wed May 27 21:05:17 2009 -0700
@@ -6,6 +6,14 @@
 	<array>
 		<dict>
 			<key>CLASS</key>
+			<string>NSApplication</string>
+			<key>LANGUAGE</key>
+			<string>ObjC</string>
+			<key>SUPERCLASS</key>
+			<string>NSResponder</string>
+		</dict>
+		<dict>
+			<key>CLASS</key>
 			<string>ESAnnouncerSpeakTextAlertDetailPane</string>
 			<key>LANGUAGE</key>
 			<string>ObjC</string>
@@ -25,14 +33,6 @@
 		</dict>
 		<dict>
 			<key>CLASS</key>
-			<string>NSApplication</string>
-			<key>LANGUAGE</key>
-			<string>ObjC</string>
-			<key>SUPERCLASS</key>
-			<string>NSResponder</string>
-		</dict>
-		<dict>
-			<key>CLASS</key>
 			<string>RBSplitView</string>
 			<key>LANGUAGE</key>
 			<string>ObjC</string>
diff -r 7981f03cce51 -r 805e6f9d8ad3 Resources/AnnouncerSpeakTextContactAlert.nib/keyedobjects.nib
Binary file Resources/AnnouncerSpeakTextContactAlert.nib/keyedobjects.nib has changed
diff -r 7981f03cce51 -r 805e6f9d8ad3 Source/AdiumSpeech.m
--- a/Source/AdiumSpeech.m	Thu May 28 00:20:01 2009 -0400
+++ b/Source/AdiumSpeech.m	Wed May 27 21:05:17 2009 -0700
@@ -188,6 +188,7 @@
 { 
 	if (!_defaultPitch) { //Cache this, since the calculation may be slow
 		NSNumber *pitchNumber = [[self defaultVoice] objectForProperty:NSSpeechPitchBaseProperty error:NULL];
+		NSLog(@"Default pitch: %@", pitchNumber);
 		if (pitchNumber) {
 			_defaultPitch = [pitchNumber floatValue];
 		} else {


More information about the commits mailing list