adium 2339:e17bcab9a10f: Replace spaces in IRC passwords when se...
commits at adium.im
commits at adium.im
Tue May 26 16:42:01 UTC 2009
details: http://hg.adium.im/adium/rev/e17bcab9a10f
revision: 2339:e17bcab9a10f
author: Zachary West <zacw at adium.im>
date: Tue May 26 12:41:54 2009 -0400
Replace spaces in IRC passwords when sending to the server, so it isn't perceived as "nick password" and we fail to understand the password is invalid.
diffstat:
ChangeLogs/Changes Between Betas.txt | 4 ++--
Plugins/Purple Service/AIIRCServicesPasswordPlugin.m | 4 +++-
2 files changed, 5 insertions(+), 3 deletions(-)
diffs (28 lines):
diff -r bc3569e7ac9e -r e17bcab9a10f ChangeLogs/Changes Between Betas.txt
--- a/ChangeLogs/Changes Between Betas.txt Mon May 25 23:01:17 2009 -0400
+++ b/ChangeLogs/Changes Between Betas.txt Tue May 26 12:41:54 2009 -0400
@@ -1,6 +1,6 @@
Adium 1.4b5
* Fixed a crash due to debug code accidentally left in b4.
* Fixed a crash/hang when moving a contact from a meta contact into a group.
+ * Fixed indeterminate errors if you provide a space in an IRC account's NickServ password.
* Changed behavior when moving a contact between groups, fixing a bug in protocols which don't support multiple groups.
- * Changed behavior when moving a contact into a meta contact: the contact is moved into the meta contact's groups.
-
\ No newline at end of file
+ * Changed behavior when moving a contact into a meta contact: the contact is moved into the meta contact's groups.
\ No newline at end of file
diff -r bc3569e7ac9e -r e17bcab9a10f Plugins/Purple Service/AIIRCServicesPasswordPlugin.m
--- a/Plugins/Purple Service/AIIRCServicesPasswordPlugin.m Mon May 25 23:01:17 2009 -0400
+++ b/Plugins/Purple Service/AIIRCServicesPasswordPlugin.m Tue May 26 12:41:54 2009 -0400
@@ -149,7 +149,9 @@
if (inPassword && inPassword.length) {
[account setValue:[NSNumber numberWithBool:YES] forProperty:@"Identifying" notify:NotifyNever];
- [(ESIRCAccount *)account identifyForName:displayName password:inPassword];
+ [(ESIRCAccount *)account identifyForName:displayName
+ password:[inPassword stringByReplacingOccurrencesOfString:@" "
+ withString:@""]];
}
}
More information about the commits
mailing list