adium 2309:1cc2db5b3d9e: Clean up some of the accessibility valu...
commits at adium.im
commits at adium.im
Sun May 24 20:27:12 UTC 2009
details: http://hg.adium.im/adium/rev/1cc2db5b3d9e
revision: 2309:1cc2db5b3d9e
author: Zachary West <zacw at adium.im>
date: Sun May 24 16:27:04 2009 -0400
Clean up some of the accessibility values for the authorization requests window.
Namely: name the table view, name the service image, and don't say "Image" for it.
diffstat:
ChangeLogs/Changes Between Betas.txt | 3 +-
Frameworks/Adium Framework/Source/AIAuthorizationRequestsWindowController.m | 13 ++++++-
2 files changed, 14 insertions(+), 2 deletions(-)
diffs (51 lines):
diff -r 09f4e9cb00f3 -r 1cc2db5b3d9e ChangeLogs/Changes Between Betas.txt
--- a/ChangeLogs/Changes Between Betas.txt Sun May 24 10:41:52 2009 -0400
+++ b/ChangeLogs/Changes Between Betas.txt Sun May 24 16:27:04 2009 -0400
@@ -3,4 +3,5 @@
* Clarified the option to only count the number of highlights/mentions in the dock/status menu item in its wording. (#12080)
* Status icon packs can now specify "Idle And Away" icons to use for contacts. (#872)
* Fixed dragging and dropping emoticon packs to reorder them. (#12099)
- * Fixed removing contacts when groups are disabled. (#12136?)
\ No newline at end of file
+ * Fixed removing contacts when groups are disabled. (#12136?)
+ * Fixed the voiceover for certain fields in the authorization requests window.
\ No newline at end of file
diff -r 09f4e9cb00f3 -r 1cc2db5b3d9e Frameworks/Adium Framework/Source/AIAuthorizationRequestsWindowController.m
--- a/Frameworks/Adium Framework/Source/AIAuthorizationRequestsWindowController.m Sun May 24 10:41:52 2009 -0400
+++ b/Frameworks/Adium Framework/Source/AIAuthorizationRequestsWindowController.m Sun May 24 16:27:04 2009 -0400
@@ -9,6 +9,7 @@
#import "AIAuthorizationRequestsWindowController.h"
#import <AIUtilities/AIToolbarUtilities.h>
#import <Adium/AIAccount.h>
+#import <Adium/AIService.h>
#import <Adium/AIServiceIcons.h>
#import <Adium/AIContactControllerProtocol.h>
#import <Adium/AIListContact.h>
@@ -64,6 +65,9 @@
name:NSWindowDidResizeNotification
object:self.window];
+ [tableView accessibilitySetOverrideValue:AILocalizedString(@"Authorization Requests", nil)
+ forAttribute:NSAccessibilityRoleDescriptionAttribute];
+
[self.window setTitle:AUTHORIZATION_REQUESTS];
}
@@ -501,9 +505,16 @@
- (void)tableView:(NSTableView *)aTableView willDisplayCell:(id)cell forTableColumn:(NSTableColumn *)tableColumn row:(NSInteger)rowIndex
{
NSString *identifier = tableColumn.identifier;
+ NSDictionary *request = [requests objectAtIndex:rowIndex];
if ([identifier isEqualToString:@"request"]) {
- [(AIImageTextCell *)cell setSubString:[[requests objectAtIndex:rowIndex] objectForKey:@"Reason"]];
+ [(AIImageTextCell *)cell setSubString:[request objectForKey:@"Reason"]];
+ } else if ([identifier isEqualToString:@"icon"]) {
+ [cell accessibilitySetOverrideValue:[[[request objectForKey:@"Account"] service] longDescription]
+ forAttribute:NSAccessibilityTitleAttribute];
+
+ [cell accessibilitySetOverrideValue:@" "
+ forAttribute:NSAccessibilityRoleDescriptionAttribute];
}
}
More information about the commits
mailing list