adium 2229:565518898c15: There's no autorelease pool in this met...
commits at adium.im
commits at adium.im
Sun May 17 20:56:48 UTC 2009
details: http://hg.adium.im/adium/rev/565518898c15
revision: 2229:565518898c15
author: David Smith <catfish.man at gmail.com>
date: Sun May 17 13:56:31 2009 -0700
There's no autorelease pool in this method, so no reason for these retains/releases. One of them was incorrect, so this fixes a leak
diffstat:
Frameworks/Adium Framework/Source/AIHTMLDecoder.m | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diffs (25 lines):
diff -r e74f9178c641 -r 565518898c15 Frameworks/Adium Framework/Source/AIHTMLDecoder.m
--- a/Frameworks/Adium Framework/Source/AIHTMLDecoder.m Sun May 17 16:23:15 2009 -0400
+++ b/Frameworks/Adium Framework/Source/AIHTMLDecoder.m Sun May 17 13:56:31 2009 -0700
@@ -357,11 +357,11 @@
}
if (color != currentColor) {
- [currentColor release]; currentColor = [color retain];
+ currentColor = color;
}
if (backColor != currentBackColor) {
- [currentBackColor release]; currentBackColor = [backColor retain];
+ currentBackColor = backColor;
}
//Close the font tag if necessary
@@ -649,7 +649,6 @@
}
[currentFamily release];
- [currentColor release];
//Finish off the HTML
if (thingsToInclude.styleTags) {
More information about the commits
mailing list