adium 2188:9432f1ab12de: Avoid over-releasing an autoreleased se...

commits at adium.im commits at adium.im
Fri May 15 00:23:20 UTC 2009


details:	http://hg.adium.im/adium/rev/9432f1ab12de
revision:	2188:9432f1ab12de
author:		Zachary West <zacw at adium.im>
date:		Thu May 14 20:23:03 2009 -0400

Avoid over-releasing an autoreleased service icons. Fixes #11985.

diffstat:

 Frameworks/Adium Framework/Source/AIServiceIcons.m |  3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diffs (20 lines):

diff -r 37f08e4d8a29 -r 9432f1ab12de Frameworks/Adium Framework/Source/AIServiceIcons.m
--- a/Frameworks/Adium Framework/Source/AIServiceIcons.m	Thu May 14 19:57:10 2009 -0400
+++ b/Frameworks/Adium Framework/Source/AIServiceIcons.m	Thu May 14 20:23:03 2009 -0400
@@ -89,6 +89,7 @@
 			if (serviceIcon) {
 				if (iconDirection == AIIconFlipped) [serviceIcon setFlipped:YES];
 				[serviceIcons[iconType][iconDirection] setObject:serviceIcon forKey:serviceID];
+				[serviceIcon release];
 			} else {
 				//Attempt to load the default service icon
 				serviceIcon = [self defaultServiceIconForType:iconType serviceID:serviceID];
@@ -98,8 +99,6 @@
 					[serviceIcons[iconType][iconDirection] setObject:serviceIcon forKey:serviceID];
 				}
 			}
-
-			[serviceIcon release];
 		}
 	}
 




More information about the commits mailing list