adium 2170:be5dc822a044: Name all our locks

commits at adium.im commits at adium.im
Wed May 13 00:50:38 UTC 2009


details:	http://hg.adium.im/adium/rev/be5dc822a044
revision:	2170:be5dc822a044
author:		David Smith <catfish.man at gmail.com>
date:		Tue May 12 17:50:21 2009 -0700

Name all our locks
Subject: adium 2171:812c0749b152: Warnings--;

details:	http://hg.adium.im/adium/rev/812c0749b152
revision:	2171:812c0749b152
author:		David Smith <catfish.man at gmail.com>
date:		Tue May 12 17:50:30 2009 -0700

Warnings--;

diffstat:

 Frameworks/AIUtilities Framework/Source/AIHostReachabilityMonitor.m |  1 +
 Frameworks/AutoHyperlinks Framework/Source/AHHyperlinkScanner.m     |  2 +-
 Source/AILogViewerWindowController.m                                |  2 ++
 Source/AILoggerPlugin.m                                             |  4 +++-
 4 files changed, 7 insertions(+), 2 deletions(-)

diffs (63 lines):

diff -r 9dfcd0593b22 -r 812c0749b152 Frameworks/AIUtilities Framework/Source/AIHostReachabilityMonitor.m
--- a/Frameworks/AIUtilities Framework/Source/AIHostReachabilityMonitor.m	Tue May 12 17:04:32 2009 -0700
+++ b/Frameworks/AIUtilities Framework/Source/AIHostReachabilityMonitor.m	Tue May 12 17:50:30 2009 -0700
@@ -55,6 +55,7 @@
 {
 	if ((self = [super init])) {
 		hostAndObserverListLock = [[NSLock alloc] init];
+		[hostAndObserverListLock setName:@"HostAndObserverListLock"];
 
 		[hostAndObserverListLock lock];
 		hosts          = [[NSMutableArray alloc] init];
diff -r 9dfcd0593b22 -r 812c0749b152 Frameworks/AutoHyperlinks Framework/Source/AHHyperlinkScanner.m
--- a/Frameworks/AutoHyperlinks Framework/Source/AHHyperlinkScanner.m	Tue May 12 17:04:32 2009 -0700
+++ b/Frameworks/AutoHyperlinks Framework/Source/AHHyperlinkScanner.m	Tue May 12 17:50:30 2009 -0700
@@ -75,7 +75,7 @@
 #pragma mark Initialization
 + (void)initialize
 {
-	if ((self = [AHHyperlinkScanner class])) {
+	if ((self == [AHHyperlinkScanner class])) {
 		if (!skipSet) {
 			NSMutableCharacterSet *mutableSkipSet = [[NSMutableCharacterSet alloc] init];
 			[mutableSkipSet formUnionWithCharacterSet:[NSCharacterSet whitespaceAndNewlineCharacterSet]];
diff -r 9dfcd0593b22 -r 812c0749b152 Source/AILogViewerWindowController.m
--- a/Source/AILogViewerWindowController.m	Tue May 12 17:04:32 2009 -0700
+++ b/Source/AILogViewerWindowController.m	Tue May 12 17:50:30 2009 -0700
@@ -200,12 +200,14 @@
 		logToGroupDict = [[NSMutableDictionary alloc] init];
 		resultsLock = [[NSRecursiveLock alloc] init];
 		searchingLock = [[NSLock alloc] init];
+		[searchingLock setName:@"LogSearchingLock"];
 		contactIDsToFilter = [[NSMutableSet alloc] initWithCapacity:1];
 
 		allContactsIdentifier = [[NSNumber numberWithInteger:-1] retain];
 
 		undoManager = [[NSUndoManager alloc] init];
 		currentSearchLock = [[NSLock alloc] init];
+		[currentSearchLock setName:@"CurrentLogSearchLock"];
 	}
 	
 	return self;
diff -r 9dfcd0593b22 -r 812c0749b152 Source/AILoggerPlugin.m
--- a/Source/AILoggerPlugin.m	Tue May 12 17:04:32 2009 -0700
+++ b/Source/AILoggerPlugin.m	Tue May 12 17:50:30 2009 -0700
@@ -173,7 +173,9 @@
 	stopIndexingThreads = NO;
 	suspendDirtyArraySave = NO;		
 	indexingThreadLock = [[NSLock alloc] init];
+	[indexingThreadLock setName:@"LogIndexingThreadLock"];
 	dirtyLogLock = [[NSLock alloc] init];
+	[dirtyLogLock setName:@"DirtyLogLock"];
 	logWritingLock = [[NSConditionLock alloc] initWithCondition:AIIndexFileAvailable];
 	logClosingLock = [[NSConditionLock alloc] initWithCondition:AIIndexFileAvailable];
 
@@ -888,7 +890,7 @@
 																toPath:newFile
 																 error:&err];
 						if (err)
-							AILogWithSignature([err localizedDescription]);
+							AILogWithSignature(@"%@", [err localizedDescription]);
 					}
 				}
 				




More information about the commits mailing list