adium 2133:d1ec0dde6808: The logic of selectively returning no b...

commits at adium.im commits at adium.im
Mon May 11 01:10:28 UTC 2009


details:	http://hg.adium.im/adium/rev/d1ec0dde6808
revision:	2133:d1ec0dde6808
author:		Zachary West <zacw at adium.im>
date:		Sun May 10 21:10:11 2009 -0400

The logic of selectively returning no based off container was causing meta contacts a lot of grief.

Always return NO to an offline contact for visibility. Fixes #11828.

diffstat:

 Frameworks/Adium Framework/Source/AIContactHidingController.m |  9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diffs (19 lines):

diff -r 551c9646dacb -r d1ec0dde6808 Frameworks/Adium Framework/Source/AIContactHidingController.m
--- a/Frameworks/Adium Framework/Source/AIContactHidingController.m	Sun May 10 16:59:11 2009 -0400
+++ b/Frameworks/Adium Framework/Source/AIContactHidingController.m	Sun May 10 21:10:11 2009 -0400
@@ -160,13 +160,8 @@
 	
 	BOOL online = listObject.online || [listObject boolValueForProperty:@"Signed Off"] || [listObject boolValueForProperty:@"New Object"];
 	
-	if (!online) {
-		if (showOfflineContacts) {
-			if (useOfflineGroup && container != adium.contactController.offlineGroup)
-				return NO;
-		} else
-			return NO;
-	}
+	if (!showOfflineContacts && !online)
+		return NO;
 		
 	if (!showIdleContacts && [listObject boolValueForProperty:@"IsIdle"])
 		return NO;




More information about the commits mailing list