[Adium-commits] adium 2056:21b77b18ba6c: Actually load the metas and collapsed g...

adium-commits at adiumx.com adium-commits at adiumx.com
Sat May 2 08:04:56 UTC 2009


details:	http://hg.adiumx.com/adium/rev/21b77b18ba6c
revision:	2056:21b77b18ba6c
author:		Colin Barrett <colin at springsandstruts.com>
date:		Sat May 02 00:40:51 2009 -0700

Actually load the metas and collapsed groups tooltip plugin. Fixes a regression introduced in 1679180a5b2d.
Subject: adium 2057:0df7a0c889c0: Fail noisily when we fail to find a core component, not just when it fails to init. Also remove two "core" components that were removed on 12/05/07 (adium-old 5fdf6cc66d36) and 6/17/05 (adium-old e5c66329428b) !!!

details:	http://hg.adiumx.com/adium/rev/0df7a0c889c0
revision:	2057:0df7a0c889c0
author:		Colin Barrett <colin at springsandstruts.com>
date:		Sat May 02 01:04:49 2009 -0700

Fail noisily when we fail to find a core component, not just when it fails to init. Also remove two "core" components that were removed on 12/05/07 (adium-old 5fdf6cc66d36) and 6/17/05 (adium-old e5c66329428b) !!!

diffstat:

 Source/AICoreComponentLoader.m |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (39 lines):

diff -r ed056bb6c400 -r 0df7a0c889c0 Source/AICoreComponentLoader.m
--- a/Source/AICoreComponentLoader.m	Fri May 01 19:17:07 2009 -0400
+++ b/Source/AICoreComponentLoader.m	Sat May 02 01:04:49 2009 -0700
@@ -83,7 +83,6 @@
 		@"AIContactStatusColoringPlugin",
 		@"AIContactStatusDockOverlaysPlugin",
 		@"AIContactStatusEventsPlugin",
-		@"AIDefaultFormattingPlugin",
 		@"AIDockAccountStatusPlugin",
 		@"AIDockBehaviorPlugin",
 		@"AIDockUnviewedContentPlugin",
@@ -118,7 +117,7 @@
 		@"ESContactClientPlugin",
 		@"ESContactServersideDisplayName",
 		@"ESFileTransferMessagesPlugin",
-		@"ESMetaContactContentsPlugin",
+		@"AIListObjectContentsPlugin",
 		@"ESOpenMessageWindowContactAlertPlugin",
 		@"ESSafariLinkToolbarItemPlugin",
 		@"ESSendMessageContactAlertPlugin",
@@ -145,7 +144,6 @@
 		@"AINulRemovalPlugin",
 		@"AIAdvancedPreferencesPlugin",
 		@"GBImportPlugin",
-		@"AIContactVisibilityPlugin",
 		@"AIMentionEventPlugin",
 		@"AITwitterIMPlugin",
 		@"AITwitterPlugin",
@@ -181,7 +179,9 @@
 
 			[components setObject:object forKey:className];
 			[object release];
-		}
+        } else {
+            NSAssert1(NO, @"Failed to load %@", className);
+        }
 		[pool release];
 #ifdef COMPONENT_LOAD_TIMING
 		NSTimeInterval t = -[start timeIntervalSinceNow];




More information about the commits mailing list