adium 2472:724bdc7a81eb: warnings--; (...on clang). The openChat...

commits at adium.im commits at adium.im
Tue Jun 9 23:20:23 UTC 2009


details:	http://hg.adium.im/adium/rev/724bdc7a81eb
revision:	2472:724bdc7a81eb
author:		David Smith <catfish.man at gmail.com>
date:		Tue Jun 09 16:20:08 2009 -0700

warnings--; (...on clang). The openChats thing was due to a GCC bug, so I think accepting the GCC warning is better than doing it wrong.

diffs (25 lines):

diff -r 1518e0c7ca44 -r 724bdc7a81eb Frameworks/Adium Framework/Source/AIChatControllerProtocol.h
--- a/Frameworks/Adium Framework/Source/AIChatControllerProtocol.h	Tue Jun 09 16:01:59 2009 -0700
+++ b/Frameworks/Adium Framework/Source/AIChatControllerProtocol.h	Tue Jun 09 16:20:08 2009 -0700
@@ -35,8 +35,7 @@
 - (BOOL)closeChat:(AIChat *)inChat;
 - (void)accountDidCloseChat:(AIChat *)inChat;
 
-//XXX Don't modify openChats. Why do we have to have its type match the ivar's type? Ugh.
- at property (nonatomic, readonly) NSMutableSet *openChats;
+ at property (nonatomic, readonly) NSSet *openChats;
 @property (nonatomic, readonly) AIChat *mostRecentUnviewedChat;
 @property (nonatomic, readonly) NSUInteger unviewedContentCount;
 @property (nonatomic, readonly) NSUInteger unviewedConversationCount;
diff -r 1518e0c7ca44 -r 724bdc7a81eb Frameworks/Adium Framework/Source/AIListGroupCell.m
--- a/Frameworks/Adium Framework/Source/AIListGroupCell.m	Tue Jun 09 16:01:59 2009 -0700
+++ b/Frameworks/Adium Framework/Source/AIListGroupCell.m	Tue Jun 09 16:20:08 2009 -0700
@@ -260,7 +260,7 @@
  * We override the paragraph style to be truncating middle.
  * The user's layout preferences may have indicated to add a shadow to the text.
  */
-- (NSDictionary *)labelAttributes
+- (NSMutableDictionary *)labelAttributes
 {
 	if (!labelAttributes) {
 		labelAttributes = super.labelAttributes;




More information about the commits mailing list