adium 2454:869b85624c29: Dammit, Zac, now you've got me doing it!

commits at adium.im commits at adium.im
Wed Jun 3 05:49:07 UTC 2009


details:	http://hg.adium.im/adium/rev/869b85624c29
revision:	2454:869b85624c29
author:		Peter Hosey <hg at boredzo.org>
date:		Tue Jun 02 22:47:45 2009 -0700

Dammit, Zac, now you've got me doing it!
Subject: adium 2455:8596de478b13: Fix handling of custom build directories containing spaces.

details:	http://hg.adium.im/adium/rev/8596de478b13
revision:	2455:8596de478b13
author:		Peter Hosey <hg at boredzo.org>
date:		Tue Jun 02 22:47:45 2009 -0700

Fix handling of custom build directories containing spaces.
Subject: adium 2456:aa9e171af640: Borrowed from Growl: Fix how our Release Makefile finds Xcode's global custom build directory.

details:	http://hg.adium.im/adium/rev/aa9e171af640
revision:	2456:aa9e171af640
author:		Peter Hosey <hg at boredzo.org>
date:		Tue Jun 02 22:48:24 2009 -0700

Borrowed from Growl: Fix how our Release Makefile finds Xcode's global custom build directory.

diffs (32 lines):

diff -r b6a5b5ae0b36 -r aa9e171af640 Release/Makefile
--- a/Release/Makefile	Tue Jun 02 18:39:16 2009 -0700
+++ b/Release/Makefile	Tue Jun 02 22:48:24 2009 -0700
@@ -76,7 +76,7 @@
 	BUILDFLAGS+="ADIUM_CFLAGS=-DBETA_RELEASE"
 endif
 
-PRODUCT_DIR=$(shell defaults read com.apple.Xcode PBXProductDirectory 2> /dev/null)
+PRODUCT_DIR=$(shell defaults read com.apple.Xcode PBXApplicationwideBuildSettings 2> /dev/null > XcodeBuildSettings.plist && defaults read $PWD/XcodeBuildSettings SYMROOT 2> /dev/null; rm XcodeBuildSettings.plist)
 
 ifeq ($(strip $(PRODUCT_DIR)),)
 	ADIUM_BUILD_DIR=$(SRC_DIR)/build/$(BUILDSTYLE)
@@ -167,7 +167,7 @@
 	mkdir $(ADIUM_DIR)
 	
 	@# copy the app
-	cp -R $(ADIUM_BUILD_DIR)/Adium.app $(ADIUM_DIR)
+	cp -R "$(ADIUM_BUILD_DIR)/Adium.app" $(ADIUM_DIR)
 
 	@# copy the text files
 	cp $(SRC_DIR)/ChangeLogs/Changes.txt $(ADIUM_DIR)
diff -r b6a5b5ae0b36 -r aa9e171af640 Source/AdiumSpeech.m
--- a/Source/AdiumSpeech.m	Tue Jun 02 18:39:16 2009 -0700
+++ b/Source/AdiumSpeech.m	Tue Jun 02 22:48:24 2009 -0700
@@ -188,7 +188,6 @@
 { 
 	if (!_defaultPitch) { //Cache this, since the calculation may be slow
 		NSNumber *pitchNumber = [[self defaultVoice] objectForProperty:NSSpeechPitchBaseProperty error:NULL];
-		NSLog(@"Default pitch: %@", pitchNumber);
 		if (pitchNumber) {
 			_defaultPitch = [pitchNumber floatValue];
 		} else {




More information about the commits mailing list