adium 3095:f774d13f8d01: Removing these #warning pragmas since w...

commits at adium.im commits at adium.im
Tue Dec 29 19:30:25 UTC 2009


details:	http://hg.adium.im/adium/rev/f774d13f8d01
revision:	3095:f774d13f8d01
author:		Stephen Holt <sholt at adium.im>
date:		Tue Dec 29 14:25:01 2009 -0500

Removing these #warning pragmas since we have a patch for replacing AIPlasticButton which only needs updating.  Refs #12974
Subject: adium 3096:456f84709ed2: Move this #warning into a task ticket.  Refs #13627

details:	http://hg.adium.im/adium/rev/456f84709ed2
revision:	3096:456f84709ed2
author:		Stephen Holt <sholt at adium.im>
date:		Tue Dec 29 14:30:17 2009 -0500

Move this #warning into a task ticket.  Refs #13627

diffs (33 lines):

diff -r c87cbb18aff2 -r 456f84709ed2 Frameworks/AIUtilities Framework/Source/AIFileManagerAdditions.m
--- a/Frameworks/AIUtilities Framework/Source/AIFileManagerAdditions.m	Tue Dec 29 13:44:29 2009 -0500
+++ b/Frameworks/AIUtilities Framework/Source/AIFileManagerAdditions.m	Tue Dec 29 14:30:17 2009 -0500
@@ -18,7 +18,6 @@
 #import <sys/types.h>
 #import <unistd.h>
 
-#warning This wants modernizing: take NSURLs, provide NSErrors
 
 @implementation NSFileManager (AIFileManagerAdditions)
 
diff -r c87cbb18aff2 -r 456f84709ed2 Frameworks/AIUtilities Framework/Source/AIPlasticButton.m
--- a/Frameworks/AIUtilities Framework/Source/AIPlasticButton.m	Tue Dec 29 13:44:29 2009 -0500
+++ b/Frameworks/AIUtilities Framework/Source/AIPlasticButton.m	Tue Dec 29 14:30:17 2009 -0500
@@ -4,7 +4,6 @@
 //
 //  Created by Adam Iser on Thu Jun 26 2003.
 //
-#warning Cocoa can do this for us now, this class (and its siblings) should go away when someone has time
 
 #import "AIPlasticButton.h"
 #import "AIPlasticButtonCell.h"
diff -r c87cbb18aff2 -r 456f84709ed2 Frameworks/AIUtilities Framework/Source/AIPlasticButtonCell.m
--- a/Frameworks/AIUtilities Framework/Source/AIPlasticButtonCell.m	Tue Dec 29 13:44:29 2009 -0500
+++ b/Frameworks/AIUtilities Framework/Source/AIPlasticButtonCell.m	Tue Dec 29 14:30:17 2009 -0500
@@ -181,7 +181,6 @@
 			fraction:1.0f];
 	
     //Draw Label
-#warning XXX handle NSCellImagePosition values other than these two correctly
 	if(imagePosition != NSImageOnly) {
 		NSString *title = [self title];
 		if (title) {




More information about the commits mailing list