adium-1.4 2889:5a2622ab6a4a: Retaining this string here makes ne...

commits at adium.im commits at adium.im
Tue Dec 22 19:08:17 UTC 2009


details:	http://hg.adium.im/adium-1.4/rev/5a2622ab6a4a
revision:	2889:5a2622ab6a4a
author:		Stephen Holt <sholt at adium.im>
date:		Tue Dec 22 14:07:15 2009 -0500

Retaining this string here makes next to no sense.  Removing the retain fixes a leak of a NSString object on every MUC user count update.

diffs (12 lines):

diff -r 7fff8467bfdd -r 5a2622ab6a4a Source/KNShelfSplitView.m
--- a/Source/KNShelfSplitView.m	Sat Dec 12 13:32:29 2009 -0500
+++ b/Source/KNShelfSplitView.m	Tue Dec 22 14:07:15 2009 -0500
@@ -720,7 +720,7 @@
 				nil];
 			
 			stringHeight = [NSAttributedString stringHeightForAttributes:attributes];
-			attributedStringValue = [[NSAttributedString alloc] initWithString:[inString retain]
+			attributedStringValue = [[NSAttributedString alloc] initWithString:inString
 																	attributes:attributes];
 		} else {
 			attributedStringValue = nil;




More information about the commits mailing list