adium 2622:209afbb6dff5: Don't leak this string.

commits at adium.im commits at adium.im
Sun Aug 23 03:10:29 UTC 2009


details:	http://hg.adium.im/adium/rev/209afbb6dff5
revision:	2622:209afbb6dff5
author:		Stephen Holt <sholt at adium.im>
date:		Sat Aug 22 18:58:10 2009 -0400

Don't leak this string.
Subject: adium 2623:80d3d47e02b0: Unit test for new string escaping case

details:	http://hg.adium.im/adium/rev/80d3d47e02b0
revision:	2623:80d3d47e02b0
author:		Stephen Holt <sholt at adium.im>
date:		Sat Aug 22 23:10:25 2009 -0400

Unit test for new string escaping case

diffs (40 lines):

diff -r 62ad02b3cf83 -r 80d3d47e02b0 Frameworks/AutoHyperlinks Framework/Source/AHMarkedHyperlink.m
--- a/Frameworks/AutoHyperlinks Framework/Source/AHMarkedHyperlink.m	Sat Aug 22 19:18:15 2009 -0700
+++ b/Frameworks/AutoHyperlinks Framework/Source/AHMarkedHyperlink.m	Sat Aug 22 23:10:25 2009 -0400
@@ -118,6 +118,7 @@
 	linkURL = [[NSURL alloc] initWithString:linkString];
 
 	[linkString release];
+	if(preString) [preString release];
 }
 
 - (void)setValidationStatus:(AH_URI_VERIFICATION_STATUS)status
diff -r 62ad02b3cf83 -r 80d3d47e02b0 Frameworks/AutoHyperlinks Framework/UnitTests/HyperlinkContextTest.m
--- a/Frameworks/AutoHyperlinks Framework/UnitTests/HyperlinkContextTest.m	Sat Aug 22 19:18:15 2009 -0700
+++ b/Frameworks/AutoHyperlinks Framework/UnitTests/HyperlinkContextTest.m	Sat Aug 22 23:10:25 2009 -0400
@@ -27,6 +27,16 @@
 	STAssertEqualObjects([[link parentString] substringWithRange:[link range]], nil, @"in context: '%@'", testString);
 }
 
+- (void)testURIEscaping:(NSString *)URIString
+{
+	NSString	*testString = [NSString stringWithFormat:@"%@", URIString];
+	AHHyperlinkScanner	*scanner = [AHHyperlinkScanner hyperlinkScannerWithString:URIString];
+	AHMarkedHyperlink	*link = [scanner nextURI];
+	
+	STAssertNotNil(link, @"-[SHHyperlinkScanner nextURL] found no URI in \"%@\"", URIString);
+	STAssertEqualObjects([[link URL] absoluteString], URIString, @"in context: '%@'", URIString);
+}
+
 #pragma mark positive tests
 - (void)testEnclosedURI:(NSString *)URIString {
 	[self testLaxContext:@"<%@>" withURI:URIString];
@@ -218,6 +228,8 @@
 	[self testLaxContext:@"foo (bar) %@" withURI:@"http://example.com/path/to/url.html"];
 	
 	[self testLaxContext:@"%@" withURI:[NSString stringWithFormat:@"%@",@"http://example.com/hi%uthere"]]; //#11160
+	
+	[self testURIEscaping:[NSString stringWithFormat:@"%@",@"http://www.google.com/search?q=foo%20bar"]]; //#12850
 }
 
 - (void)testCompositeContext {




More information about the commits mailing list