adium 2590:34bbe221bb80: Fixed retaining delegate property, intr...

commits at adium.im commits at adium.im
Wed Aug 12 07:03:09 UTC 2009


details:	http://hg.adium.im/adium/rev/34bbe221bb80
revision:	2590:34bbe221bb80
author:		Peter Hosey <hg at boredzo.org>
date:		Tue Aug 11 23:51:29 2009 -0700

Fixed retaining delegate property, introduced in 1d5619b64c61.

Believe it or not, this caused an *under*-release crash when a FT finished with the progress window closed: The delegate is a progress row, which is normally owned solely by the progress window controller. With this retention keeping the row alive, Adium crashed when the row went to talk to the now-dead progress window controller.

diffs (12 lines):

diff -r adafeb783ff9 -r 34bbe221bb80 Frameworks/Adium Framework/Source/ESFileTransfer.h
--- a/Frameworks/Adium Framework/Source/ESFileTransfer.h	Tue Aug 11 11:14:29 2009 -0400
+++ b/Frameworks/Adium Framework/Source/ESFileTransfer.h	Tue Aug 11 23:51:29 2009 -0700
@@ -72,7 +72,7 @@
 
 @property (readwrite, nonatomic, retain) id accountData;
 
- at property (readwrite, nonatomic, retain) id <FileTransferDelegate> delegate;
+ at property (readwrite, nonatomic, assign) id <FileTransferDelegate> delegate;
 
 @property (readonly, nonatomic) BOOL isStopped;
 




More information about the commits mailing list